Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 10331db8f748
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 61510db94a1c
Choose a head ref
  • 5 commits
  • 38 files changed
  • 5 contributors

Commits on Feb 28, 2024

  1. Revert "[skwasm] Clip pictures if they go beyond the bounds of the wi… 

    …ndow. (#50887)" (#51067)

This reverts commit 63b6117.

The change is causing skwasm benchmarks to flake. See https://ci.chromium.org/ui/p/flutter/builders/luci.flutter.prod/Linux%20web_benchmarks_skwasm
    @eyebrowsoffire
    eyebrowsoffire authored Feb 28, 2024
    Configuration menu
    Copy the full SHA
    49f5d96 View commit details
    Browse the repository at this point in the history

  2. Test the SurfaceTextureSurfaceProducer-branch in the Android `scena… 

    …rio_app` (#51061)

This PR does the following:
- Relands #50993.
- Fixes a bug in `SurfaceTextureSurfaceProducer` where it would crash on
release (now tested, yay!)

Closes flutter/flutter#143539.
Closes flutter/flutter#143483.

/cc @gaaclarke @chinmaygarde, this PR should (after landed) test/verify
#50730.
    @matanlurey
    matanlurey authored Feb 28, 2024
    Configuration menu
    Copy the full SHA
    ea6adb0 View commit details
    Browse the repository at this point in the history

  3. [Impeller] Cache entire render target and not just allocations. (#50990) 

    This may be required to fix flutter/flutter#144116 , and in general the safety of the render pass caches.

Because the RenderPass / Framebuffer objects refer to specific attachments, the caches are placed on the resolve texture, which is "real". The stencil/depth and or MSAA textures may be different but that didn't seem to matter on many Android devices. It doesn't seem like its actually valid though, whether or not there is a validation error to catch it.

I can confirm this fixes flutter/flutter#144116  locally.

This change moves the cache one level up to cover the properties of the RenderTarget we care about, and ensures that we always use the same attachment combinations.

Fixes flutter/flutter#141750
Maybe flutter/flutter#144255 ?
    Jonah Williams authored Feb 28, 2024
    Configuration menu
    Copy the full SHA
    5574bf5 View commit details
    Browse the repository at this point in the history

  4. Prefix flutter in flutter_vma.h import (#51065) 

    Breaks the Google build (b/327309677)
    Casey Hillers authored Feb 28, 2024
    Configuration menu
    Copy the full SHA
    b1e9854 View commit details
    Browse the repository at this point in the history

  5. Roll Skia from 27171d6a9205 to f0a60bfe98e0 (4 revisions) (#51068) 

    https://skia.googlesource.com/skia.git/+log/27171d6a9205..f0a60bfe98e0

2024-02-28 [email protected] Manual roll vulkan-deps from 83c3be5d8216 to ffd0c1c14e46 (2 revisions)
2024-02-28 [email protected] Reland "Cleanup linkage in SkSwizzler_opts.h"
2024-02-28 [email protected] Update Perlin noise GM slide.
2024-02-28 [email protected] Only define _opts functions when needed

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Feb 28, 2024
    Configuration menu
    Copy the full SHA
    61510db View commit details
    Browse the repository at this point in the history
Loading