-
Notifications
You must be signed in to change notification settings - Fork 6k
Comparing changes
Open a pull request
base repository: flutter/engine
base: 0e7248d43251
head repository: flutter/engine
compare: 4cb3ba7a85f6
- 14 commits
- 248 files changed
- 9 contributors
Commits on Dec 14, 2023
-
Remove unused metadata in DEPS from vuln scanning (#48995)
These upstream links (used in vulnerability scanning) are not needed since the references to the deps are no longer used. Part of simplifying metadata for the vuln scan process, context in b/248564768. *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].* [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Configuration menu - View commit details
-
Copy full SHA for 6fa8e76 - Browse repository at this point
Copy the full SHA 6fa8e76View commit details -
[Impeller] Turned on new blur. (#48472)
This new blur should perform faster since it scales down the image before blurring it. Jonah did early testing of it and found it to be faster. Scrolling around with the blur perf bug it seems faster. It also has a wider test bed and is hopefully easier to maintain since it contains all of its logic for both directions. testing: There are existing blur tests and we've backfilled more as we've added features to this blur. fixes flutter/flutter#131580 fixes flutter/flutter#138259 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I added new tests to check the change I am making or feature I am adding, or the PR is [test-exempt]. See [testing the engine] for instructions on writing and running engine tests. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I signed the [CLA]. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style [testing the engine]: https://github.com/flutter/flutter/wiki/Testing-the-engine [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat
Configuration menu - View commit details
-
Copy full SHA for d0464cf - Browse repository at this point
Copy the full SHA d0464cfView commit details -
Unpin mac_toolchain version (#48994)
mac_toolchain has been updated to no longer have 2 minute slowdown (flutter/flutter#138109), so unpin to use the latest version. [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Configuration menu - View commit details
-
Copy full SHA for fdae5f5 - Browse repository at this point
Copy the full SHA fdae5f5View commit details -
[Impeller] distinguish between no clear color and transparent black c…
…lear color. (#49038) If we clear to transparent black, we're not forcing the pass to be constructed. Change the entity pass API so that we can tell the difference between clearing transparent black and not having a clear color. In flutter/flutter#139571 , the app is creating a layer that is clearing to a transparent color, which is getting skipped. That invalid texture is fed into a blend which produces either black or magenta error texture. Fixes flutter/flutter#139571
Jonah Williams authoredDec 14, 2023 Configuration menu - View commit details
-
Copy full SHA for 0b0fab8 - Browse repository at this point
Copy the full SHA 0b0fab8View commit details -
Suppress warning for the new Activity library. (#49046)
Context: cl/582573869
Configuration menu - View commit details
-
Copy full SHA for 636b12c - Browse repository at this point
Copy the full SHA 636b12cView commit details -
Roll Skia from 92935b91193a to 79f23e8d8b5d (1 revision) (#49056)
https://skia.googlesource.com/skia.git/+log/92935b91193a..79f23e8d8b5d 2023-12-14 [email protected] [skif] Refine SkSpecialImage::asShader() API for fast constraints If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for 765ba27 - Browse repository at this point
Copy the full SHA 765ba27View commit details -
Rename
font-subsettofont_subset. (#49051)For consistency, I don't think we have any other tools with `-`'s. I'll be honest - this seemed easier than teaching the header guard tool how to handle `-`'s in directory names, but if you feel strongly about it I can revert.
Configuration menu - View commit details
-
Copy full SHA for 47e5480 - Browse repository at this point
Copy the full SHA 47e5480View commit details -
Manual roll of Dart SDK from a677378ae254 to 0471164827b9 (#49054)
Includes an update for a deprecated FFI API (see https://dart.googlesource.com/sdk/+/efb60eac5999e47853505f2e3fc3eaf19f56f495)
Configuration menu - View commit details
-
Copy full SHA for 8517ab3 - Browse repository at this point
Copy the full SHA 8517ab3View commit details -
Fix header-guard naming convention in
shell/. (#49006)Part of landing #48903. Some of these actually seem like potential owchy spots, i.e. `#ifndef FLUTTER_FLUTTER_H_`.
Configuration menu - View commit details
-
Copy full SHA for d883683 - Browse repository at this point
Copy the full SHA d883683View commit details
Commits on Dec 15, 2023
-
Revert "[Impeller] Turned on new blur." (#49062)
Reverts #48472 This is causing memory crashes in the device lab: https://ci.chromium.org/ui/p/flutter/builders/prod/Mac_ios%20backdrop_filter_perf_ios__timeline_summary/14324/overview ``` [2023-12-14 15:55:20.660354] [STDOUT] stdout: [+1764 ms] Process 611 stopped [2023-12-14 15:55:20.662620] [STDOUT] stdout: [ +2 ms] * thread #12, name = 'io.flutter.1.raster', stop reason = EXC_RESOURCE (RESOURCE_TYPE_MEMORY: high watermark memory limit exceeded) (limit=2098 MB) [2023-12-14 15:55:20.662686] [STDOUT] stdout: [ ] frame #0: 0x0000000106705e78 Flutter`void std::_LIBCPP_ABI_NAMESPACE::allocator<impeller::Command>::construct[abi:v15000]<impeller::Command, impeller::Command>(impeller::Command*, impeller::Command&&) + 8 [2023-12-14 15:55:20.662784] [STDOUT] stdout: [ ] Flutter`std::_LIBCPP_ABI_NAMESPACE::allocator<impeller::Command>::construct[abi:v15000]<impeller::Command, impeller::Command>: [2023-12-14 15:55:20.662883] [STDOUT] stdout: [ ] -> 0x106705e78 <+8>: str x8, [x0] [2023-12-14 15:55:20.662932] [STDOUT] stdout: [ ] 0x106705e7c <+12>: ldr x8, [x1, #0x8] [2023-12-14 15:55:20.663033] [STDOUT] stdout: [ ] 0x106705e80 <+16>: str x8, [x0, #0x8] [2023-12-14 15:55:20.663097] [STDOUT] stdout: [ ] 0x106705e84 <+20>: ldr x8, [x1, #0x10] [2023-12-14 15:55:20.663194] [STDOUT] stdout: [ ] Target 0: (Runner) stopped. [2023-12-14 15:55:20.663309] [STDOUT] stdout: [ ] thread backtrace all [2023-12-14 15:55:20.663403] [STDOUT] stdout: [ ] process detach ```
Configuration menu - View commit details
-
Copy full SHA for 9b716e0 - Browse repository at this point
Copy the full SHA 9b716e0View commit details -
[Impeller] split out gradient tests from aiks_unittests (#49050)
issue flutter/flutter#140106 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Configuration menu - View commit details
-
Copy full SHA for 882849b - Browse repository at this point
Copy the full SHA 882849bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 223a8a1 - Browse repository at this point
Copy the full SHA 223a8a1View commit details -
Roll Dart SDK from 0471164827b9 to f1e37ed8917e (1 revision) (#49065)
https://dart.googlesource.com/sdk.git/+log/0471164827b9..f1e37ed8917e 2023-12-15 [email protected] Version 3.3.0-231.0.dev If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dart-sdk-flutter-engine Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for a498cd3 - Browse repository at this point
Copy the full SHA a498cd3View commit details -
Roll Skia from 79f23e8d8b5d to cd2f06086c96 (1 revision) (#49069)
https://skia.googlesource.com/skia.git/+log/79f23e8d8b5d..cd2f06086c96 2023-12-15 [email protected] Roll vulkan-deps from d4bd313283e0 to 65af791e6a06 (5 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for 4cb3ba7 - Browse repository at this point
Copy the full SHA 4cb3ba7View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 0e7248d43251...4cb3ba7a85f6