Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 0e7248d43251
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 4cb3ba7a85f6
Choose a head ref
  • 14 commits
  • 248 files changed
  • 9 contributors

Commits on Dec 14, 2023

  1. Remove unused metadata in DEPS from vuln scanning (#48995)

    These upstream links (used in vulnerability scanning) are not needed since the references to the deps are no longer used. 
    Part of simplifying metadata for the vuln scan process, context in b/248564768.
    
    *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
    
    [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    sealesj authored Dec 14, 2023
    Configuration menu
    Copy the full SHA
    6fa8e76 View commit details
    Browse the repository at this point in the history
  2. [Impeller] Turned on new blur. (#48472)

    This new blur should perform faster since it scales down the image
    before blurring it. Jonah did early testing of it and found it to be
    faster. Scrolling around with the blur perf bug it seems faster. It also
    has a wider test bed and is hopefully easier to maintain since it
    contains all of its logic for both directions.
    
    testing: There are existing blur tests and we've backfilled more as
    we've added features to this blur.
    
    fixes flutter/flutter#131580
    fixes flutter/flutter#138259
    
    ## Pre-launch Checklist
    
    - [x] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [x] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [x] I read and followed the [Flutter Style Guide] and the [C++,
    Objective-C, Java style guides].
    - [x] I listed at least one issue that this PR fixes in the description
    above.
    - [x] I added new tests to check the change I am making or feature I am
    adding, or the PR is [test-exempt]. See [testing the engine] for
    instructions on writing and running engine tests.
    - [x] I updated/added relevant documentation (doc comments with `///`).
    - [x] I signed the [CLA].
    - [x] All existing and new tests are passing.
    
    If you need help, consider asking for advice on the #hackers-new channel
    on [Discord].
    
    <!-- Links -->
    [Contributor Guide]:
    https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
    [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
    [test-exempt]:
    https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
    [Flutter Style Guide]:
    https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
    [C++, Objective-C, Java style guides]:
    https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    [testing the engine]:
    https://github.com/flutter/flutter/wiki/Testing-the-engine
    [CLA]: https://cla.developers.google.com/
    [flutter/tests]: https://github.com/flutter/tests
    [breaking change policy]:
    https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
    [Discord]: https://github.com/flutter/flutter/wiki/Chat
    gaaclarke authored Dec 14, 2023
    Configuration menu
    Copy the full SHA
    d0464cf View commit details
    Browse the repository at this point in the history
  3. Unpin mac_toolchain version (#48994)

    mac_toolchain has been updated to no longer have 2 minute slowdown (flutter/flutter#138109), so unpin to use the latest version.
    
    [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    vashworth authored Dec 14, 2023
    Configuration menu
    Copy the full SHA
    fdae5f5 View commit details
    Browse the repository at this point in the history
  4. [Impeller] distinguish between no clear color and transparent black c…

    …lear color. (#49038)
    
    If we clear to transparent black, we're not forcing the pass to be constructed. Change the entity pass API so that we can tell the difference between clearing transparent black and not having a clear color.
    
    In flutter/flutter#139571 , the app is creating a layer that is clearing to a transparent color, which is getting skipped. That invalid texture is fed into a blend which produces either black or magenta error texture.
    
    Fixes flutter/flutter#139571
    Jonah Williams authored Dec 14, 2023
    Configuration menu
    Copy the full SHA
    0b0fab8 View commit details
    Browse the repository at this point in the history
  5. Suppress warning for the new Activity library. (#49046)

    Context: cl/582573869
    chingjun authored Dec 14, 2023
    Configuration menu
    Copy the full SHA
    636b12c View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    765ba27 View commit details
    Browse the repository at this point in the history
  7. Rename font-subset to font_subset. (#49051)

    For consistency, I don't think we have any other tools with `-`'s.
    
    I'll be honest - this seemed easier than teaching the header guard tool
    how to handle `-`'s in directory names, but if you feel strongly about
    it I can revert.
    matanlurey authored Dec 14, 2023
    Configuration menu
    Copy the full SHA
    47e5480 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    8517ab3 View commit details
    Browse the repository at this point in the history
  9. Fix header-guard naming convention in shell/. (#49006)

    Part of landing #48903.
    
    Some of these actually seem like potential owchy spots, i.e. `#ifndef FLUTTER_FLUTTER_H_`.
    matanlurey authored Dec 14, 2023
    Configuration menu
    Copy the full SHA
    d883683 View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2023

  1. Revert "[Impeller] Turned on new blur." (#49062)

    Reverts #48472
    
    This is causing memory crashes in the device lab:
    https://ci.chromium.org/ui/p/flutter/builders/prod/Mac_ios%20backdrop_filter_perf_ios__timeline_summary/14324/overview
    ```
    [2023-12-14 15:55:20.660354] [STDOUT] stdout: [+1764 ms] Process 611 stopped
    [2023-12-14 15:55:20.662620] [STDOUT] stdout: [   +2 ms] * thread #12, name = 'io.flutter.1.raster', stop reason = EXC_RESOURCE (RESOURCE_TYPE_MEMORY: high watermark memory limit exceeded) (limit=2098 MB)
    [2023-12-14 15:55:20.662686] [STDOUT] stdout: [        ]     frame #0: 0x0000000106705e78 Flutter`void std::_LIBCPP_ABI_NAMESPACE::allocator<impeller::Command>::construct[abi:v15000]<impeller::Command, impeller::Command>(impeller::Command*, impeller::Command&&) + 8
    [2023-12-14 15:55:20.662784] [STDOUT] stdout: [        ] Flutter`std::_LIBCPP_ABI_NAMESPACE::allocator<impeller::Command>::construct[abi:v15000]<impeller::Command, impeller::Command>:
    [2023-12-14 15:55:20.662883] [STDOUT] stdout: [        ] ->  0x106705e78 <+8>:  str    x8, [x0]
    [2023-12-14 15:55:20.662932] [STDOUT] stdout: [        ]     0x106705e7c <+12>: ldr    x8, [x1, #0x8]
    [2023-12-14 15:55:20.663033] [STDOUT] stdout: [        ]     0x106705e80 <+16>: str    x8, [x0, #0x8]
    [2023-12-14 15:55:20.663097] [STDOUT] stdout: [        ]     0x106705e84 <+20>: ldr    x8, [x1, #0x10]
    [2023-12-14 15:55:20.663194] [STDOUT] stdout: [        ] Target 0: (Runner) stopped.
    [2023-12-14 15:55:20.663309] [STDOUT] stdout: [        ] thread backtrace all
    [2023-12-14 15:55:20.663403] [STDOUT] stdout: [        ] process detach
    ```
    gaaclarke authored Dec 15, 2023
    Configuration menu
    Copy the full SHA
    9b716e0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    882849b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    223a8a1 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    a498cd3 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    4cb3ba7 View commit details
    Browse the repository at this point in the history
Loading