Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 0c1de9b8afba
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 4c62dd81d136
Choose a head ref
  • 4 commits
  • 14 files changed
  • 4 contributors

Commits on Aug 3, 2023

  1. Roll Skia from bae32428c1c7 to 3b3c1a617544 (1 revision) (#44345) 

    https://skia.googlesource.com/skia.git/+log/bae32428c1c7..3b3c1a617544

2023-08-03 [email protected] Roll vulkanmemoryallocator to latest

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Aug 3, 2023
    Configuration menu
    Copy the full SHA
    0838f9b View commit details
    Browse the repository at this point in the history

  2. [Impeller] Discard invalid command buffer handles after destroying a … 

    …command pool (#44194)

Fixes flutter/flutter#131522
    @jason-simmons
    jason-simmons authored Aug 3, 2023
    Configuration menu
    Copy the full SHA
    8bee0dc View commit details
    Browse the repository at this point in the history

  3. Reland "[web] Update text editing test skips" (#37655)

    @harryterkelsen
    harryterkelsen authored Aug 3, 2023
    Configuration menu
    Copy the full SHA
    6555ecd View commit details
    Browse the repository at this point in the history

  4. [Impeller] Run clangd tidy, opting out in 2 cases. (#44351) 

    Many `#include`s, particularly in the `impeller/renderer/backend/vulkan/...` directory, had existing `clangd` lint violations.

The most frequent and easiest to fix appears to be https://clangd.llvm.org/guides/include-cleaner.

---

Note that I used `// IWYU pragma: keep.` in two places where `clangd` wasn't able to tell something was in use. In other cases you'll see additions because files were relying on transitive includes that are removed in this PR, but there should be 0 behavioral changes!
    @matanlurey
    matanlurey authored Aug 3, 2023
    Configuration menu
    Copy the full SHA
    4c62dd8 View commit details
    Browse the repository at this point in the history
Loading