Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 0bcea845cd31
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 9b51e30a4d37
Choose a head ref
  • 4 commits
  • 15 files changed
  • 4 contributors

Commits on Dec 12, 2024

  1. [Impeller] Fix a race in the ReactorGLES.PerThreadOperationQueues test ( 

    #57147)

Pass a flag to AddOperation to ensure that ReactorGLES does not immediately execute the operation on the second thread.
    @jason-simmons
    jason-simmons authored Dec 12, 2024
    Configuration menu
    Copy the full SHA
    590985b View commit details
    Browse the repository at this point in the history

  2. Format _empty.dart (#57144) 

    When `dartfmt` formatted `_empty.dart` it formatted it with a trailing newline, which then makes the license script angry. Rather then treating `_empty.dart` special, this just makes it a regular source file with header and everything.
    @goderbauer
    goderbauer authored Dec 12, 2024
    Configuration menu
    Copy the full SHA
    730df7a View commit details
    Browse the repository at this point in the history

  3. Roll Dart SDK from 770ff2b085fc to 02aa27c6a075 (1 revision) (#57161) 

    https://dart.googlesource.com/sdk.git/+log/770ff2b085fc..02aa27c6a075

2024-12-12 [email protected] Version 3.7.0-243.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Dec 12, 2024
    Configuration menu
    Copy the full SHA
    a98f8c8 View commit details
    Browse the repository at this point in the history

  4. iOS: Reduce engine/view controller coupling (#57151) 

    Eliminates some cases where `FlutterViewController` was relying on `FlutterEngine` internals:
* `[FlutterEngine shell]`
* `[FlutterEngine platformView]`
* `[FlutterEngine iosPlatformView]`

Instead, `FlutterEngine` now exposes:
* `installFirstFrameCallback:`
* `enableSemantics:withFlags:`
* `notifyViewCreated`
* `notifyViewDestroyed`
* `waitForFirstFrameSync:callback:`

Also fixes a couple cases where we were relying on transitive header includes:
* `FlutterAppController` relied on `FlutterViewController_Internal.h` for `sendDeepLinkToFramework:completionHandler:`

This is a refactoring followup to #57099 that introduces no semantic changes.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    @cbracken
    cbracken authored Dec 12, 2024
    Configuration menu
    Copy the full SHA
    9b51e30 View commit details
    Browse the repository at this point in the history
Loading