Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 0b9fce355df9
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 4bc368ee5f74
Choose a head ref
  • 3 commits
  • 62 files changed
  • 3 contributors

Commits on Jan 24, 2024

  1. Replace Fuchsia logging macros (FX_LOG*) with FML logging (#49970) 

    This change updates all of the Fuchsia specific logging macros (e.g.
FX_LOG*) to use the logging macros provided by the FML library
(FML_LOG(...)). This will allow us to migrate to Fuchsia structured
logging backend in a future commit.

flutter/flutter#141924
    @mbrase
    mbrase authored Jan 24, 2024
    Configuration menu
    Copy the full SHA
    f2bdc5a View commit details
    Browse the repository at this point in the history

  2. Roll Skia from c353c00a4dcb to 9ea7cb490804 (1 revision) (#50005) 

    https://skia.googlesource.com/skia.git/+log/c353c00a4dcb..9ea7cb490804

2024-01-24 [email protected] Add SK_API to SkString free functions.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Jan 24, 2024
    Configuration menu
    Copy the full SHA
    c8f564e View commit details
    Browse the repository at this point in the history

  3. [Impeller] use const std::unique_ptr ref for Sampler type. (#49974) 

    The backend specific sampler libraries hold a strong reference to the native sampler objects and never clear this cache. As a result of this, we don't theoretically need rendering commands to increment a shared_ptr ref count - instead the sampler library can provide the Sampler object as a const ref and guarantee that it continues to be valid.

This allows us to reduce the amount of refcount ops for commands that use samplers.

Additionally, the sampler library uses nullptr as a sentinel for failing to construct a sampler object. Since sampler already has an isValid member that is checked - we can replace this with a specific invalid object subtype.
    Jonah Williams authored Jan 24, 2024
    Configuration menu
    Copy the full SHA
    4bc368e View commit details
    Browse the repository at this point in the history
Loading