Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 0a098bd6f761
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 2be719150ea9
Choose a head ref
  • 5 commits
  • 38 files changed
  • 10 contributors

Commits on Nov 27, 2023

  1. [Impeller] updated gaussian blur tests to use device private textures (… 

    …#48417)

fixes flutter/flutter#138955

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
    @gaaclarke
    gaaclarke authored Nov 27, 2023
    Configuration menu
    Copy the full SHA
    44c8eb8 View commit details
    Browse the repository at this point in the history

  2. [canvaskit] Enable multiview rendering (#48301) 

    Allows the CanvasKitRenderer to render into multiple views.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat

---------

Co-authored-by: skia-flutter-autoroll <[email protected]>
Co-authored-by: Mouad Debbar <[email protected]>
Co-authored-by: 林洵锋 <[email protected]>
Co-authored-by: Brandon DeRosier <[email protected]>
Co-authored-by: Jonah Williams <[email protected]>
Co-authored-by: Matej Knopp <[email protected]>
    @harryterkelsen @skia-flutter-autoroll
    @mdebbar @LinXunFeng @bdero @knopp
    7 people authored Nov 27, 2023
    Configuration menu
    Copy the full SHA
    37002c3 View commit details
    Browse the repository at this point in the history

  3. Roll Skia from 4c964f8c4738 to 600986ba305d (6 revisions) (#48419) 

    https://skia.googlesource.com/skia.git/+log/4c964f8c4738..600986ba305d

2023-11-27 [email protected] [skif] Add per-testcase control over image diffing parameters
2023-11-27 [email protected] Roll vulkan-deps from fab2f1d6619c to 9aac6a34e9ad (5 revisions)
2023-11-27 [email protected] Non-substantive cleanup
2023-11-27 [email protected] [skif] Extract relevantSubset() bounds+tilemode helper
2023-11-27 [email protected] Avoid needlessly enabling VK_KHR_dynamic_rendering extension
2023-11-27 [email protected] [graphite] Add Protected BackendTexture tests

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Nov 27, 2023
    Configuration menu
    Copy the full SHA
    da8b45c View commit details
    Browse the repository at this point in the history

  4. Roll shaderc to google/shaderc@37e2553 (#48415) 

    Captures changes to expose vulkan relaxed rules when compiling GLSL shaders.
    @dnfield
    dnfield authored Nov 27, 2023
    Configuration menu
    Copy the full SHA
    91c9e27 View commit details
    Browse the repository at this point in the history

  5. Dynamic view sizing [dart:ui] (#48090) 

    Towards flutter/flutter#134501.

This PR makes the following changes to the public dart:ui API:

* It adds the `FlutterView.pysicalConstraints` property that describes max and min width and height for a view. The framework is allowed to size the `FlutterView` to any `Size` that meets these constraints.
* It adds an optional `size` argument to `FlutterView.render`. The framework provides the chosen `Size` that meets the aforementioned constraints to the `render` method. If the `FlutterView.pysicalConstraints` are tight (minHeight == maxHeight and minWidth == maxWidth) the argument is optional to remain backwards compatible. In all other cases, a `Size` must be provided.
* It adds a `ViewConstraints` class, which is basically the `dart:ui` version of `BoxConstraints` (This is similar to how we have `ViewPadding` in dart:ui to mirror `EdgeInsets` from the framework). It describes the constraints of a `FlutterView`, i.e. it powers the `FlutterView.pysicalConstraints` property.

This change does not wire anything up to the embedders. For now, `FlutterView.pysicalConstraints` just returns tight constraints for the embedder-provided size of the view (`FlutterView.physicalSize`) and the size provided to `FlutterView.render` is ignored (after it is checked that it meets the constrains). 

This PR enables the framework to implement the new dynamic view sizing and embedders to separately expose the new functionality to their clients.

Presubmits will fail until flutter/flutter#138565 is submitted to the framework.

**DO NOT SUBMIT until flutter/flutter#138648 is ready.**
    @goderbauer
    goderbauer authored Nov 27, 2023
    Configuration menu
    Copy the full SHA
    2be7191 View commit details
    Browse the repository at this point in the history
Loading