Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 090fae83548a
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 08aaa88bf67f
Choose a head ref
  • 3 commits
  • 12 files changed
  • 2 contributors

Commits on Jun 21, 2023

  1. Generate treemap. (#43029) 

    Engine V2 was not generating the size treemap. This change will start uploading the size treemap to the test logs.

Bug: flutter/flutter#128482

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    @godofredoc
    godofredoc authored Jun 21, 2023
    Configuration menu
    Copy the full SHA
    f09280c View commit details
    Browse the repository at this point in the history

  2. Document the use of contexts on engine_v2 tests. (#43013) 

    Contexts are predefined python contexts that can be dynamically added to the test execution.

Bug: flutter/flutter#129187

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    @godofredoc
    godofredoc authored Jun 21, 2023
    Configuration menu
    Copy the full SHA
    08c6507 View commit details
    Browse the repository at this point in the history

  3. Enabling pre-push checks on Windows (#36123) 

    Re-submit the changes to enable windows pre-push checks.

This patch changes how `ci/bin/format.dart` generate diffs from `diff` and `patch` commands to `git diff` and `git apply` in order to have a common method for these operations on all platforms. Windows installations don't have diff and patch commands available by default and many implementations which provide such commands work differently than the UN*X tools. Git however works consistently across all platforms.

Additionally, this patch also changes the python executable in some of the pre-push components affected by this to `vpython3` to continue the effort started at flutter/flutter#108474 and I also removed the `--no-sound-null-safety` parameter in the ci/format.sh, ci/format.bat files

NOTE: Since the original patch caused some issues, I suggest that this should be tested more carefully before it is merged.

### Issues fixed by this PR
* flutter/flutter#108122
* flutter/flutter#107920
* flutter/flutter#86506
* flutter/flutter#106615

### [flutter/tests] repo impact
None.

writing and running engine tests.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    @mtolmacs
    mtolmacs authored Jun 21, 2023
    Configuration menu
    Copy the full SHA
    08aaa88 View commit details
    Browse the repository at this point in the history
Loading