Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 0774ddcda9b0
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 06696e768c1b
Choose a head ref
  • 4 commits
  • 3 files changed
  • 3 contributors

Commits on Sep 11, 2023

  1. Remove some of our hacks around JSPromise now that we have better API… 

    …s. (#45591)

Our JSPromise hackery is causing some issues with the new dart roll. We should just use the `JSPromise` and `JSFunction` support to simplify this. Note that I still have to do *some* hackery to construct `JSPromise` objects and to invoke `JSFunction` objects, and eventually we'll probably be able to simplify this even more once those APIs are baked into `dart:js_interop`
    @eyebrowsoffire
    eyebrowsoffire authored Sep 11, 2023
    Configuration menu
    Copy the full SHA
    f192cc9 View commit details
    Browse the repository at this point in the history

  2. Update skwasm build to use safer flush call (#45652) 

    Follow-up to #45644

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
    @kjlubick
    kjlubick authored Sep 11, 2023
    Configuration menu
    Copy the full SHA
    d671b2d View commit details
    Browse the repository at this point in the history

  3. Roll Skia from 3ed290acb65f to e6225224fb4e (2 revisions) (#45658) 

    https://skia.googlesource.com/skia.git/+log/3ed290acb65f..e6225224fb4e

2023-09-11 [email protected] Add a few more UTF-16 paragraph APIs
2023-09-11 [email protected] Roll jsfiddle-base from 2e999b8eedf7 to 420bf03c7a80

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Sep 11, 2023
    Configuration menu
    Copy the full SHA
    0f7729d View commit details
    Browse the repository at this point in the history

  4. Revert "Remove some of our hacks around JSPromise now that we have be… 

    …tter APIs." (#45660)

Reverts #45591

This is somehow causing some issues with the hot reload tests and blocking engine -> framework rolls. See flutter/flutter#134455
    @eyebrowsoffire
    eyebrowsoffire authored Sep 11, 2023
    Configuration menu
    Copy the full SHA
    06696e7 View commit details
    Browse the repository at this point in the history
Loading