Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 06448ee8165f
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 0f3ad23b84ed
Choose a head ref
  • 16 commits
  • 29 files changed
  • 9 contributors

Commits on Feb 22, 2024

  1. Reverts "[Impeller] cache onscreen render targets. (#50751)" (#50871) 

    Reverts #50751

Initiated by: jonahwilliams

Reason for reverting: breaking flutter tester --enable-impeller workflow

Original PR Author: jonahwilliams

Reviewed By: {matanlurey}

This change reverts the following previous change:
Original Description:
Currently we cache render pass objects to offscreen render targets only. Caching onscreen doesn't work as 1) the render targets are stored on the texture_vk object and 2) the texture_vk object is recreated for each frame (see https://github.com/flutter/engine/blob/main/impeller/renderer/backend/vulkan/surface_vk.cc#L14 ).

To make sure the render pass is cached, move the storage to the texture source.

part of flutter/flutter#141750
    @auto-submit
    auto-submit[bot] authored Feb 22, 2024
    Configuration menu
    Copy the full SHA
    749ae65 View commit details
    Browse the repository at this point in the history

  2. Use RBE on more Windows builders (#50866)

    @zanderso
    zanderso authored Feb 22, 2024
    Configuration menu
    Copy the full SHA
    05ffcb1 View commit details
    Browse the repository at this point in the history

  3. Reverts "Remove WindowManager reflection in SingleViewPresentation.ja… 

    …va (#49996)" (#50873)

Reverts #49996

Initiated by: gmackall

Reason for reverting: b/326363243 

Original PR Author: gmackall

Reviewed By: {johnmccutchan, reidbaker}

This change reverts the following previous change:
Original Description:
Fixes flutter/flutter#106449. Changes it to a static proxy, as the comment recommended. This does mean we will have to update it to override new methods as they are added to the interface when updating the version of the Android sdk we use.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    @auto-submit
    auto-submit[bot] authored Feb 22, 2024
    Configuration menu
    Copy the full SHA
    e922da6 View commit details
    Browse the repository at this point in the history

  4. [Impeller] Add stroke benchmarks that create UVs with no transform (#… 

    …50847)

The current stroke benchmarks exercise their PositionUVWriter variants with a worst case texture mapping that includes an effect transform. These benchmarks won't track any improvements we make to the case that does not include a transform.

This PR adds new benchmarks that track performance of computing texture coords with just a set of texture bounds and no transform.
    @flar
    flar authored Feb 22, 2024
    Configuration menu
    Copy the full SHA
    843ecc5 View commit details
    Browse the repository at this point in the history

  5. Implement frame timing callbacks in Skwasm. (#50737) 

    Fixes flutter/flutter#140429

Some notes here:
* Refactored the frame timing systems so that we can deal with asynchronous rendering.
* Consolidated rendering of multiple pictures in skwasm into a single call, so that the rasterization can be properly measured.
* Pulled the frame timings tests into the `ui` test suite so that they run on all renderers (including skwasm).
    @eyebrowsoffire
    eyebrowsoffire authored Feb 22, 2024
    Configuration menu
    Copy the full SHA
    3ee6f25 View commit details
    Browse the repository at this point in the history

  6. Pass the missing strut half leading flag over to skia paragraph build… 

    …er (#50385)

Not sure how this can be tested. Part of flutter/flutter#142969

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    @LongCatIsLooong
    LongCatIsLooong authored Feb 22, 2024
    Configuration menu
    Copy the full SHA
    bd7c9d7 View commit details
    Browse the repository at this point in the history

  7. Remove 'bringup: true' from 'Mac mac_unopt' (#50865) 

    Second half of flutter/flutter#142010
    @zanderso
    zanderso authored Feb 22, 2024
    Configuration menu
    Copy the full SHA
    9bf1cec View commit details
    Browse the repository at this point in the history

  8. Roll Skia from b9c16065b76d to dd8cd405d145 (2 revisions) (#50872) 

    https://skia.googlesource.com/skia.git/+log/b9c16065b76d..dd8cd405d145

2024-02-22 [email protected] Revert "Add TextShaper back to normal srcs"
2024-02-22 [email protected] Add TextShaper back to normal srcs

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Feb 22, 2024
    Configuration menu
    Copy the full SHA
    fbc4160 View commit details
    Browse the repository at this point in the history

  9. Delete and create iOS simulator before running Scenario app test (#50835 

    )

Make iOS Scenario app tests create the simulator it needs before the tests. Also, delete any existing matching simulators to prevent duplicates.

Fixes flutter/flutter#143870.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    @vashworth
    vashworth authored Feb 22, 2024
    Configuration menu
    Copy the full SHA
    547c834 View commit details
    Browse the repository at this point in the history

  10. Avoid generated plugin registrant warnings for scenario_app (#50874) 

    Cleans up some noise in those logs.
    @dnfield
    dnfield authored Feb 22, 2024
    Configuration menu
    Copy the full SHA
    cb6115d View commit details
    Browse the repository at this point in the history

  11. Roll Skia from dd8cd405d145 to a285cd79614c (3 revisions) (#50878) 

    https://skia.googlesource.com/skia.git/+log/dd8cd405d145..a285cd79614c

2024-02-22 [email protected] [graphite] Add support for text atlas garbage collection.
2024-02-22 [email protected] Add TextShaper back to modules/skottie/src/text:srcs (Take 2)
2024-02-22 [email protected] Change a local_defines to defines

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Feb 22, 2024
    Configuration menu
    Copy the full SHA
    5088c37 View commit details
    Browse the repository at this point in the history

  12. Build macOS engine as an xcframework (#50300) 

    Creates and adds FlutterMacOS.xcframework to out/mac or out/host.

Creates and archives FlutterMacOS.xcframework when building mac_host_engine. Archives the xcframework in a new zipped folder at `darwin-x64/framework.zip`, `darwin-x64-profile/framework.zip`, `darwin-x64-release/framework.zip`.

The FlutterMacOS.framework is also still archived currently - I thought it'd be better to keep it archived so we don't have to worry about the tool breaking until we're ready to remove it.

Part of flutter/flutter#126016.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    @vashworth
    vashworth authored Feb 22, 2024
    Configuration menu
    Copy the full SHA
    73a6e07 View commit details
    Browse the repository at this point in the history

  13. [Impeller] moved the kernel size assert to a more appropriate locatio… 

    …n. (#50880)

This is the more appropriate location for the assert now.  This is important if we want to fiddle with the downsample amount now the the kernel is effectively half as big.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    @gaaclarke
    gaaclarke authored Feb 22, 2024
    Configuration menu
    Copy the full SHA
    c5d2e01 View commit details
    Browse the repository at this point in the history

  14. Roll Skia from a285cd79614c to 58772db6bc46 (3 revisions) (#50884) 

    https://skia.googlesource.com/skia.git/+log/a285cd79614c..58772db6bc46

2024-02-22 [email protected] [bazel] Linux targets: Annotate with target_compatible_with.
2024-02-22 [email protected] Move Perlin noise Type enum out of the class.
2024-02-22 [email protected] [bazel] Test runners: Delete miscellaneous non-modular-build targets.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Feb 22, 2024
    Configuration menu
    Copy the full SHA
    7c5eddf View commit details
    Browse the repository at this point in the history

  15. Roll Dart SDK from 0f0f7400c38a to e2f2d9b464e9 (4 revisions) (#50881) 

    https://dart.googlesource.com/sdk.git/+log/0f0f7400c38a..e2f2d9b464e9

2024-02-22 [email protected] Version 3.4.0-167.0.dev
2024-02-22 [email protected] Version 3.4.0-166.0.dev
2024-02-22 [email protected] Version 3.4.0-165.0.dev
2024-02-22 [email protected] Version 3.4.0-164.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Feb 22, 2024
    Configuration menu
    Copy the full SHA
    4d8aadc View commit details
    Browse the repository at this point in the history

  16. Reverts "Implement frame timing callbacks in Skwasm. (#50737)" (#50895) 

    Reverts #50737

Initiated by: goderbauer

Reason for reverting: Fails in device lab, see https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8755350727803344657/+/u/run_web_benchmarks_skwasm/stdout

Original PR Author: eyebrowsoffire

Reviewed By: {mdebbar, yjbanov}

This change reverts the following previous change:
Original Description:
Fixes flutter/flutter#140429

Some notes here:
* Refactored the frame timing systems so that we can deal with asynchronous rendering.
* Consolidated rendering of multiple pictures in skwasm into a single call, so that the rasterization can be properly measured.
* Pulled the frame timings tests into the `ui` test suite so that they run on all renderers (including skwasm).
    @auto-submit
    auto-submit[bot] authored Feb 22, 2024
    Configuration menu
    Copy the full SHA
    0f3ad23 View commit details
    Browse the repository at this point in the history
Loading