Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 036b39fa47fa
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: a35e3b026e1d
Choose a head ref
  • 6 commits
  • 11 files changed
  • 4 contributors

Commits on Jan 9, 2024

  1. Roll Skia from ee263c34e03d to 05039d6ed8d8 (2 revisions) (#49636) 

    https://skia.googlesource.com/skia.git/+log/ee263c34e03d..05039d6ed8d8

2024-01-09 [email protected] Fixup unit tests for Protected Vulkan
2024-01-09 [email protected] Simplify SkRP pop-condition-mask followed by a matching push.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Jan 9, 2024
    Configuration menu
    Copy the full SHA
    f2330bd View commit details
    Browse the repository at this point in the history

  2. Migrate to Flutter mirrors for Google-owned Github repositories (#49203) 

    Flutter dependencies coming from Github origins need to be mirrored so that they are not taken directly from github. This is part of an effort to standardize the dependency sources from third party dependencies.

Google is creating internal mirrors for these public repos, but we would be limited by the relatively strict access placed on those new repos, requiring this solution of Flutter GoB mirrors (as has already been done with non-Google Github repos and also Fuchsia-owned mirrors)

*List which issues are fixed by this PR. You must list at least one issue.*
Addresses b/316597637

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    @sealesj
    sealesj authored Jan 9, 2024
    Configuration menu
    Copy the full SHA
    f989a55 View commit details
    Browse the repository at this point in the history

  3. Resize the RenderTarget before creating and passing its Surface to th… 

    …e VirtualDisplay (#49619)

This change ensures that we first set the default buffer size on the
underlying SurfaceTexture before creating the Surface for it.

This fixes a bug that only occurs on Android devices running 28 or
older: see flutter/flutter#141068.

This also removes some unnecessary init code and cleans up tests.
    @johnmccutchan
    johnmccutchan authored Jan 9, 2024
    Configuration menu
    Copy the full SHA
    ad6f192 View commit details
    Browse the repository at this point in the history

  4. Skip flaky test on mac in http_disallow_http_connections_test.dart (#… 

    …49635)

Related flutter/flutter#141149
    @zanderso
    zanderso authored Jan 9, 2024
    Configuration menu
    Copy the full SHA
    833cbe6 View commit details
    Browse the repository at this point in the history

  5. Roll Skia from 05039d6ed8d8 to 8c8be76a62c0 (3 revisions) (#49638) 

    https://skia.googlesource.com/skia.git/+log/05039d6ed8d8..8c8be76a62c0

2024-01-09 [email protected] Reland "[graphite] Add Graphite version of WrapAndroidHardwareBuffer"
2024-01-09 [email protected] Have SkMipmap::Build return nullptr on mipmap allocation failure
2024-01-09 [email protected] Allow overriding raster pipeline's CPU level via #define

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Jan 9, 2024
    Configuration menu
    Copy the full SHA
    210d722 View commit details
    Browse the repository at this point in the history

  6. Simplify PlatformViewRenderTarget interface (#49639) 

    - Enable ImageReader/SurfaceProducer backends for Android >= 29.
- This removes the need for a weird Android 29-specific fix in
SurfaceTexturePlatformViewRenderTarget.
- Now that we don't need the weird fix we can simplify the
PlatformViewRenderTarget interface.
    @johnmccutchan
    johnmccutchan authored Jan 9, 2024
    Configuration menu
    Copy the full SHA
    a35e3b0 View commit details
    Browse the repository at this point in the history
Loading