Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 019f9e3f0744
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 5909666fdedb
Choose a head ref
  • 12 commits
  • 17 files changed
  • 8 contributors

Commits on Aug 13, 2024

  1. [fuchsia] Use BundledTestRunner from test-scripts (#54404)

    The BundledTestRunner has been moved to chromium already, flutter can now use it without needing to reimplement the same logic.
    
    The logic of parsing yaml file is still flutter specific and keeps as-is.
    
    Bug: http://crbug.com/356463343
    
    [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    zijiehe-google-com authored Aug 13, 2024
    Configuration menu
    Copy the full SHA
    cd1e0d9 View commit details
    Browse the repository at this point in the history
  2. Preserve background frame damage (#54540)

    Fixes flutter/flutter#153335
    
    When platform views are present, we always repaint entire frame. We must pass the buffer damage all the way to `GPUSurfaceMetalSkia/GPUSurfaceMetalImpeller` so that they know that the other two surfaces are lagging behind front surface and need to be repainted.
    
    This is currently not being done with platform view present, that's why we miss full frame repaint when removing platform view.
    
    With this merged in, it should be safe to reland #54537 without any changes.
    
    [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    knopp authored Aug 13, 2024
    Configuration menu
    Copy the full SHA
    9cec8c2 View commit details
    Browse the repository at this point in the history
  3. [canvaskit] Add animation detection for GIFs (#54483)

    Detect if a GIF is animated to determine if we need to use Skia to decode it or if we can use <img> tag decoding.
    
    Fixes flutter/flutter#151911
    
    [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    harryterkelsen authored Aug 13, 2024
    Configuration menu
    Copy the full SHA
    2fcb51a View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    10062bb View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    f16aeed View commit details
    Browse the repository at this point in the history
  6. macOS: Clean up create_ios_framework.py (#54543)

    Over time, this script and others in sky/tools have accumulated a lot of additional and sometimes duplicate code.
    
    This is a first pass cleanup of create_macos_framework.py to extract common utility code to utils.py and refactor for better readability.
    
    The iOS analogue of this patch was #54500.
    
    [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    cbracken authored Aug 13, 2024
    Configuration menu
    Copy the full SHA
    0339bfe View commit details
    Browse the repository at this point in the history
  7. Update dartdoc for gpu.dart (#54529)

    Update dartdoc for package:flutter_gpu with:
    1) details on how to use the sdk dep
    2) the current docs link
    
    [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    mit-mit authored Aug 13, 2024
    Configuration menu
    Copy the full SHA
    ce73a8b View commit details
    Browse the repository at this point in the history
  8. [DisplayList] Allow random access to ops through indexing (#54484)

    Being able to reorder rendering commands leads to optimization opportunities in the graphics package. A graphics package being fed from a DisplayList either has to take the commands in the order given or implement their own storage format for the rendering data.
    
    With this new dispatching mechanism, the graphics package can both query basic information about the recorded ops and even dispatch them by the index into the list. Query information includes either the "category" of the op (clip/transform/render, etc.) or a specific op type enum. The package can dispatch some categories (or ops) immediately and remember other categories (or ops) along with their state for dispatching later.
    flar authored Aug 13, 2024
    Configuration menu
    Copy the full SHA
    db034a5 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2024

  1. macOS: refactor create_macos_framework.py (#54546)

    This is a refactoring with no semantic changes.
    
    This refactors the macOS framework creation code to be more readable, and extracts it to sky_utils.py.
    
    While I was pulling this out, also generalised the code to not hardcode FlutterMacOS.framework in case we one day manage to generate the iOS and macOS frameworks with the same name.
    
    [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    cbracken authored Aug 14, 2024
    Configuration menu
    Copy the full SHA
    69f61b0 View commit details
    Browse the repository at this point in the history
  2. Reverts "macOS: refactor create_macos_framework.py (#54546)" (#54549)

    Reverts: #54546
    Initiated by: zanderso
    Reason for reverting: Failing roll flutter/flutter#153406
    Original PR Author: cbracken
    
    Reviewed By: {zanderso}
    
    This change reverts the following previous change:
    This is a refactoring with no semantic changes.
    
    This refactors the macOS framework creation code to be more readable, and extracts it to sky_utils.py.
    
    While I was pulling this out, also generalised the code to not hardcode FlutterMacOS.framework in case we one day manage to generate the iOS and macOS frameworks with the same name.
    
    [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    auto-submit[bot] authored Aug 14, 2024
    Configuration menu
    Copy the full SHA
    23b6090 View commit details
    Browse the repository at this point in the history
  3. Reverts "macOS: Clean up create_ios_framework.py (#54543)" (#54550)

    Reverts: #54543
    Initiated by: zanderso
    Reason for reverting: Failing roll flutter/flutter#153406
    Original PR Author: cbracken
    
    Reviewed By: {zanderso}
    
    This change reverts the following previous change:
    Over time, this script and others in sky/tools have accumulated a lot of additional and sometimes duplicate code.
    
    This is a first pass cleanup of create_macos_framework.py to extract common utility code to utils.py and refactor for better readability.
    
    The iOS analogue of this patch was #54500.
    
    [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    auto-submit[bot] authored Aug 14, 2024
    Configuration menu
    Copy the full SHA
    087e290 View commit details
    Browse the repository at this point in the history
  4. Reverts "Roll Dart SDK from 44635f897535 to 733062367c2e (1 revision) (

    …#54541)" (#54552)
    
    Reverts: #54541
    Initiated by: zanderso
    Reason for reverting: Analyzer change incorrectly flags unused final field as uninitialized? https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8739656817167901393/+/u/run_test.dart_for_customer_testing_shard_and_subshard_None/stdout
    Original PR Author: skia-flutter-autoroll
    
    Reviewed By: {fluttergithubbot}
    
    This change reverts the following previous change:
    
    https://dart.googlesource.com/sdk.git/+log/44635f897535..733062367c2e
    
    2024-08-13 [email protected] Version 3.6.0-147.0.dev
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/dart-sdk-flutter-engine
    Please CC [email protected],[email protected] on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    auto-submit[bot] authored Aug 14, 2024
    Configuration menu
    Copy the full SHA
    5909666 View commit details
    Browse the repository at this point in the history
Loading