Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit f771a1f

Browse files
committed
Skip deep constant nesting test on Windows dart2js. It crashes infrastructure.
Bug: dart-lang/sdk#37631 These tests cause the dart2js batch mode compiler process to resist termination somehow on Windows, which locks the dart.exe executable and prevents sharding task cleanup. Change-Id: Ica19e9d262f0b5b97c263205ba6fac030a3bedb7 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110444 Reviewed-by: Ryan Macnak <[email protected]>
1 parent fbcbb83 commit f771a1f

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

tests/language_2/language_2_dart2js.status

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -246,6 +246,10 @@ round_test: Fail, OK # Common JavaScript engine Math.round bug.
246246
stacktrace_test: RuntimeError
247247

248248
[ $compiler == dart2js && $system == windows ]
249+
canonicalization_hashing_memoize_array_test: Skip # Issue 37631
250+
canonicalization_hashing_memoize_instance_test: Skip # Issue 37631
251+
canonicalization_hashing_shallow_collision_array_test: Skip # Issue 37631
252+
canonicalization_hashing_shallow_collision_instance_test: Skip # Issue 37631
249253
string_literals_test: Pass, RuntimeError # Failures on dart2js-win7-chrome-4-4-be and dart2js-win7-ie11ff-4-4-be
250254

251255
[ $compiler == dart2js && $checked ]

0 commit comments

Comments
 (0)