Cache font family lookups that fail to obtain a font collection (#10109)

jason-simmons · web-flow · commit f742514a5642 · 2019-07-24T11:33:04.000-07:00
diff --git a/third_party/txt/src/txt/font_collection.cc b/third_party/txt/src/txt/font_collection.cc
@@ -159,6 +159,7 @@ FontCollection::GetMinikinFontCollectionForFamilies(
   }
   // Default font family also not found. We fail to get a FontCollection.
   if (minikin_families.empty()) {
+    font_collections_cache_[family_key] = nullptr;
     return nullptr;
   }
   if (enable_font_fallback_) {

Original file line number	Diff line number	Diff line change
`@@ -159,6 +159,7 @@ FontCollection::GetMinikinFontCollectionForFamilies(`
`159`	`159`	`}`
`160`	`160`	`// Default font family also not found. We fail to get a FontCollection.`
`161`	`161`	`if (minikin_families.empty()) {`
	`162`	`+ font_collections_cache_[family_key] = nullptr;`
`162`	`163`	`return nullptr;`
`163`	`164`	`}`
`164`	`165`	`if (enable_font_fallback_) {`