Fix iOS keyboard crash (#10656)

Qxyat · cbracken · commit e95125aad331 · 2019-08-12T11:35:35.000-07:00
Fixes an iOS crash on physical devices in `-[__NSCFString substringWithRange:]`: range out of bounds. According to Apple's docs for `UITextInput` method `positionFromPosition:(UITextPosition*)position offset:(NSInteger)offset`, this method should return:

A custom UITextPosition object that represents the location in a document that is at the specified offset from position. Return nil if the computed text position is less than 0 or greater than the length of the backing string.
diff --git a/shell/platform/darwin/ios/framework/Source/FlutterTextInputPlugin.mm b/shell/platform/darwin/ios/framework/Source/FlutterTextInputPlugin.mm
@@ -433,6 +433,12 @@ - (NSUInteger)incrementOffsetPosition:(NSUInteger)position {
 
 - (UITextPosition*)positionFromPosition:(UITextPosition*)position offset:(NSInteger)offset {
   NSUInteger offsetPosition = ((FlutterTextPosition*)position).index;
+
+  NSInteger newLocation = (NSInteger)offsetPosition + offset;
+  if (newLocation < 0 || newLocation > (NSInteger)self.text.length) {
+    return nil;
+  }
+
   if (offset >= 0) {
     for (NSInteger i = 0; i < offset && offsetPosition < self.text.length; ++i)
       offsetPosition = [self incrementOffsetPosition:offsetPosition];
