Prepare texture for cross context usage when using the Metal backend.

chinmaygarde · Skia Commit-Bot · commit cf573d844da6 · 2020-03-07T00:59:32.000Z
This implementation will only work when the two contexts are created using the same device and command queue. This restriction is now applied in Flutter. With the patch and context setup, async texture uploads on the IO thread are functional. Change-Id: I887d24b2612cde933e088f74f33912a3a8762159 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/275758 Commit-Queue: Chinmay Garde <chinmaygarde@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com> Auto-Submit: Chinmay Garde <chinmaygarde@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com>
diff --git a/src/gpu/mtl/GrMtlGpu.h b/src/gpu/mtl/GrMtlGpu.h
@@ -100,9 +100,7 @@ class GrMtlGpu : public GrGpu {
     void insertSemaphore(GrSemaphore* semaphore) override;
     void waitSemaphore(GrSemaphore* semaphore) override;
     void checkFinishProcs() override;
-    std::unique_ptr<GrSemaphore> prepareTextureForCrossContextUsage(GrTexture*) override {
-        return nullptr;
-    }
+    std::unique_ptr<GrSemaphore> prepareTextureForCrossContextUsage(GrTexture*) override;
 
     // When the Metal backend actually uses indirect command buffers, this function will actually do
     // what it says. For now, every command is encoded directly into the primary command buffer, so
diff --git a/src/gpu/mtl/GrMtlGpu.mm b/src/gpu/mtl/GrMtlGpu.mm
@@ -226,6 +226,11 @@ static bool get_feature_set(id<MTLDevice> device, MTLFeatureSet* featureSet) {
     }
 }
 
+std::unique_ptr<GrSemaphore> GrMtlGpu::prepareTextureForCrossContextUsage(GrTexture*) {
+    submitCommandBuffer(SyncQueue::kSkip_SyncQueue);
+    return nullptr;
+}
+
 sk_sp<GrGpuBuffer> GrMtlGpu::onCreateBuffer(size_t size, GrGpuBufferType type,
                                             GrAccessPattern accessPattern, const void* data) {
     return GrMtlBuffer::Make(this, size, type, accessPattern, data);

Original file line number	Diff line number	Diff line change
`@@ -226,6 +226,11 @@ static bool get_feature_set(id<MTLDevice> device, MTLFeatureSet* featureSet) {`
`226`	`226`	`}`
`227`	`227`	`}`
`228`	`228`
	`229`	`+std::unique_ptr<GrSemaphore> GrMtlGpu::prepareTextureForCrossContextUsage(GrTexture*) {`
	`230`	`+ submitCommandBuffer(SyncQueue::kSkip_SyncQueue);`
	`231`	`+ return nullptr;`
	`232`	`+}`
	`233`	`+`
`229`	`234`	`sk_sp<GrGpuBuffer> GrMtlGpu::onCreateBuffer(size_t size, GrGpuBufferType type,`
`230`	`235`	`GrAccessPattern accessPattern, const void* data) {`
`231`	`236`	`return GrMtlBuffer::Make(this, size, type, accessPattern, data);`