Raise API level for reportFullyDrawn (#14146) (#15937)

dnfield · tvolkert · commit b1bb773396a7 · 2020-01-23T09:55:47.000-08:00
diff --git a/shell/platform/android/io/flutter/embedding/android/FlutterActivity.java b/shell/platform/android/io/flutter/embedding/android/FlutterActivity.java
@@ -938,7 +938,9 @@ public boolean shouldAttachEngineToActivity() {
   public void onFlutterUiDisplayed() {
     // Notifies Android that we're fully drawn so that performance metrics can be collected by
     // Flutter performance tests.
-    if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.KITKAT) {
+    // This was supported in KitKat (API 19), but has a bug around requiring
+    // permissions. See https://github.com/flutter/flutter/issues/46172
+    if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.LOLLIPOP) {
       reportFullyDrawn();
     }
   }

Original file line number	Diff line number	Diff line change
`@@ -938,7 +938,9 @@ public boolean shouldAttachEngineToActivity() {`
`938`	`938`	`public void onFlutterUiDisplayed() {`
`939`	`939`	`// Notifies Android that we're fully drawn so that performance metrics can be collected by`
`940`	`940`	`// Flutter performance tests.`
`941`		`- if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.KITKAT) {`
	`941`	`+ // This was supported in KitKat (API 19), but has a bug around requiring`
	`942`	`+ // permissions. See https://github.com/flutter/flutter/issues/46172`
	`943`	`+ if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.LOLLIPOP) {`
`942`	`944`	`reportFullyDrawn();`
`943`	`945`	`}`
`944`	`946`	`}`