Fix the CanvasPath::CreateNew signature to avoid unnecessary Dart API::NewError calls (#32791)

jason-simmons · web-flow · commit a9dafdb97913 · 2022-04-20T07:24:04.000-07:00
diff --git a/lib/ui/painting/path.h b/lib/ui/painting/path.h
@@ -24,7 +24,7 @@ class CanvasPath : public RefCountedDartWrappable<CanvasPath> {
 
  public:
   ~CanvasPath() override;
-  static fml::RefPtr<CanvasPath> CreateNew(Dart_Handle path_handle) {
+  static fml::RefPtr<CanvasPath> CreateNew() {
     return fml::MakeRefCounted<CanvasPath>();
   }
 
diff --git a/third_party/tonic/converter/dart_converter.h b/third_party/tonic/converter/dart_converter.h
@@ -560,7 +560,9 @@ struct DartConverter<Dart_Handle> {
   static NativeType FromArguments(Dart_NativeArguments args,
                                   int index,
                                   Dart_Handle& exception) {
-    return Dart_GetNativeArgument(args, index);
+    Dart_Handle result = Dart_GetNativeArgument(args, index);
+    TONIC_DCHECK(!Dart_IsError(result));
+    return result;
   }
 
   static NativeType FromFfi(FfiType val) { return val; }

Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,7 @@ class CanvasPath : public RefCountedDartWrappable<CanvasPath> {`
`24`	`24`
`25`	`25`	`public:`
`26`	`26`	`~CanvasPath() override;`
`27`		`- static fml::RefPtr<CanvasPath> CreateNew(Dart_Handle path_handle) {`
	`27`	`+ static fml::RefPtr<CanvasPath> CreateNew() {`
`28`	`28`	`return fml::MakeRefCounted<CanvasPath>();`
`29`	`29`	`}`
`30`	`30`