Revert "Revert "Remove unnecessary entry-point closurization. (#7827)" (#7876)" (#7904)

dnfield · web-flow · commit 93eeb48baee5 · 2019-02-21T10:57:31.000-08:00
This reverts commit f45572e.
diff --git a/lib/stub_ui/natives.dart b/lib/stub_ui/natives.dart
@@ -20,7 +20,7 @@ Future<developer.ServiceExtensionResponse> _scheduleFrame(
   }));
 }
 
-@pragma('vm:entry-point')
+@pragma('vm:entry-point', 'call')
 void _setupHooks() {  // ignore: unused_element
   assert(() {
     // In debug mode, register the schedule frame extension.
diff --git a/lib/ui/hooks.dart b/lib/ui/hooks.dart
@@ -16,7 +16,7 @@ dynamic _decodeJSON(String message) {
   return message != null ? json.decode(message) : null;
 }
 
-@pragma('vm:entry-point')
+@pragma('vm:entry-point', 'call')
 // ignore: unused_element
 void _updateWindowMetrics(double devicePixelRatio,
                           double width,
@@ -54,11 +54,11 @@ String _localeClosure() {
   return window.locale.toString();
 }
 
-@pragma('vm:entry-point')
+@pragma('vm:entry-point', 'call')
 // ignore: unused_element
 _LocaleClosure _getLocaleClosure() => _localeClosure;
 
-@pragma('vm:entry-point')
+@pragma('vm:entry-point', 'call')
 // ignore: unused_element
 void _updateLocales(List<String> locales) {
   const int stringsPerLocale = 4;
@@ -77,7 +77,7 @@ void _updateLocales(List<String> locales) {
   _invoke(window.onLocaleChanged, window._onLocaleChangedZone);
 }
 
-@pragma('vm:entry-point')
+@pragma('vm:entry-point', 'call')
 // ignore: unused_element
 void _updateUserSettingsData(String jsonData) {
   final Map<String, dynamic> data = json.decode(jsonData);
@@ -103,14 +103,14 @@ void _updatePlatformBrightness(String brightnessName) {
   _invoke(window.onPlatformBrightnessChanged, window._onPlatformBrightnessChangedZone);
 }
 
-@pragma('vm:entry-point')
+@pragma('vm:entry-point', 'call')
 // ignore: unused_element
 void _updateSemanticsEnabled(bool enabled) {
   window._semanticsEnabled = enabled;
   _invoke(window.onSemanticsEnabledChanged, window._onSemanticsEnabledChangedZone);
 }
 
-@pragma('vm:entry-point')
+@pragma('vm:entry-point', 'call')
 // ignore: unused_element
 void _updateAccessibilityFeatures(int values) {
   final AccessibilityFeatures newFeatures = new AccessibilityFeatures._(values);
@@ -120,7 +120,7 @@ void _updateAccessibilityFeatures(int values) {
   _invoke(window.onAccessibilityFeaturesChanged, window._onAccessibilityFlagsChangedZone);
 }
 
-@pragma('vm:entry-point')
+@pragma('vm:entry-point', 'call')
 void _dispatchPlatformMessage(String name, ByteData data, int responseId) {
   if (window.onPlatformMessage != null) {
     _invoke3<String, ByteData, PlatformMessageResponseCallback>(
@@ -137,14 +137,14 @@ void _dispatchPlatformMessage(String name, ByteData data, int responseId) {
   }
 }
 
-@pragma('vm:entry-point')
+@pragma('vm:entry-point', 'call')
 // ignore: unused_element
 void _dispatchPointerDataPacket(ByteData packet) {
   if (window.onPointerDataPacket != null)
     _invoke1<PointerDataPacket>(window.onPointerDataPacket, window._onPointerDataPacketZone, _unpackPointerDataPacket(packet));
 }
 
-@pragma('vm:entry-point')
+@pragma('vm:entry-point', 'call')
 // ignore: unused_element
 void _dispatchSemanticsAction(int id, int action, ByteData args) {
   _invoke3<int, SemanticsAction, ByteData>(
@@ -156,13 +156,13 @@ void _dispatchSemanticsAction(int id, int action, ByteData args) {
   );
 }
 
-@pragma('vm:entry-point')
+@pragma('vm:entry-point', 'call')
 // ignore: unused_element
 void _beginFrame(int microseconds) {
   _invoke1<Duration>(window.onBeginFrame, window._onBeginFrameZone, new Duration(microseconds: microseconds));
 }
 
-@pragma('vm:entry-point')
+@pragma('vm:entry-point', 'call')
 // ignore: unused_element
 void _drawFrame() {
   _invoke(window.onDrawFrame, window._onDrawFrameZone);
@@ -173,7 +173,7 @@ typedef _UnaryFunction(Null args);
 // ignore: always_declare_return_types, prefer_generic_function_type_aliases
 typedef _BinaryFunction(Null args, Null message);
 
-@pragma('vm:entry-point')
+@pragma('vm:entry-point', 'call')
 // ignore: unused_element
 void _runMainZoned(Function startMainIsolateFunction, Function userMainFunction) {
   startMainIsolateFunction((){
diff --git a/lib/ui/natives.dart b/lib/ui/natives.dart
@@ -29,7 +29,7 @@ Future<developer.ServiceExtensionResponse> _scheduleFrame(
   }));
 }
 
-@pragma('vm:entry-point')
+@pragma('vm:entry-point', 'call')
 void _setupHooks() {  // ignore: unused_element
   assert(() {
     // In debug mode, register the schedule frame extension.
@@ -71,7 +71,7 @@ Function _getCallbackFromHandle(int handle) native 'GetCallbackFromHandle';
 // Required for gen_snapshot to work correctly.
 int _isolateId; // ignore: unused_element
 
-@pragma('vm:entry-point')
+@pragma('vm:entry-point', 'call')
 Function _getPrintClosure() => _print;  // ignore: unused_element
-@pragma('vm:entry-point')
+@pragma('vm:entry-point', 'call')
 Function _getScheduleMicrotaskClosure() => _scheduleMicrotask; // ignore: unused_element

Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,7 @@ Future<developer.ServiceExtensionResponse> _scheduleFrame(`
`20`	`20`	`}));`
`21`	`21`	`}`
`22`	`22`
`23`		`-@pragma('vm:entry-point')`
	`23`	`+@pragma('vm:entry-point', 'call')`
`24`	`24`	`void _setupHooks() { // ignore: unused_element`
`25`	`25`	`assert(() {`
`26`	`26`	`// In debug mode, register the schedule frame extension.`