Do not pass short-lived buffers as labels to Dart_TimelineEvent (#8166)

jason-simmons · web-flow · commit 403337ebb893 · 2019-03-14T12:49:42.000-07:00
Dart no longer makes a copy of the label string when recording events. See #8152
diff --git a/fml/trace_event.h b/fml/trace_event.h
@@ -205,12 +205,12 @@ void TraceEventFlowEnd0(TraceArg category_group, TraceArg name, TraceIDArg id);
 
 class ScopedInstantEnd {
  public:
-  ScopedInstantEnd(std::string str) : label_(std::move(str)) {}
+  ScopedInstantEnd(const char* str) : label_(str) {}
 
-  ~ScopedInstantEnd() { TraceEventEnd(label_.c_str()); }
+  ~ScopedInstantEnd() { TraceEventEnd(label_); }
 
  private:
-  const std::string label_;
+  const char* label_;
 
   FML_DISALLOW_COPY_AND_ASSIGN(ScopedInstantEnd);
 };
