Add “full-dart-debug” that disabled optimizations in the Dart VM. (#8147)

chinmaygarde · web-flow · commit 3c93817839bd · 2019-03-13T12:54:57.000-07:00
diff --git a/tools/gn b/tools/gn
@@ -139,6 +139,10 @@ def to_gn_args(args):
     if args.dart_debug:
         gn_args['dart_debug'] = True
 
+    if args.full_dart_debug:
+      gn_args['dart_debug'] = True
+      gn_args['dart_debug_optimization_level'] = '0'
+
     if args.target_os == 'android':
         gn_args['target_cpu'] = args.android_cpu
     elif args.target_os == 'ios':
@@ -247,7 +251,10 @@ def parse_args(args):
   parser.add_argument('--runtime-mode', type=str, choices=['debug', 'profile', 'release'], default='debug')
   parser.add_argument('--dynamic', default=False, action='store_true')
   parser.add_argument('--interpreter', default=False, action='store_true')
-  parser.add_argument('--dart-debug', default=False, action='store_true')
+  parser.add_argument('--dart-debug', default=False, action='store_true', help='Enables assertsion in the Dart VM. ' +
+      'Does not affect affect optimization levels. If you need to disable optimizations in Dart, use --full-dart-debug')
+  parser.add_argument('--full-dart-debug', default=False, action='store_true', help='Implies --dart-debug ' +
+      'and also disables optimizations in the Dart VM making it easier to step through VM code in the debugger.')
 
   parser.add_argument('--target-os', type=str, choices=['android', 'ios', 'linux'])
   parser.add_argument('--android', dest='target_os', action='store_const', const='android')
