Handle NULL 'value' to eglGetSyncAttribKHR()

Alistair Strachan · Alistair Strachan · commit 179c932426b3 · 2019-03-27T20:58:50.000Z
The EGL spec does not specifically call out how to handle the case where 'value' passed to eglGetSyncAttribKHR is NULL, however many implementations will set the context error to EGL_BAD_PARAMETER and return without crashing. dEQP has a test which specifically checks for this behavior. Align SwiftShader's implementation with other EGL implementations. Bug: b/74572503 Test: dEQP-EQL GetSyncInvalidValueTest Change-Id: Ic893cd7073c12c463ded78042031df1bf85f6ce2 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/28028 Reviewed-by: Nicolas Capens <nicolascapens@google.com> Tested-by: Alistair Strachan <astrachan@google.com>
diff --git a/src/OpenGL/libEGL/libEGL.cpp b/src/OpenGL/libEGL/libEGL.cpp
@@ -1417,6 +1417,11 @@ EGLBoolean GetSyncAttrib(EGLDisplay dpy, EGLSyncKHR sync, EGLint attribute, EGLA
 		return error(EGL_BAD_PARAMETER, EGL_FALSE);
 	}
 
+	if(!value)
+	{
+		return error(EGL_BAD_PARAMETER, EGL_FALSE);
+	}
+
 	switch(attribute)
 	{
 	case EGL_SYNC_TYPE_KHR:

Original file line number	Diff line number	Diff line change
`@@ -1417,6 +1417,11 @@ EGLBoolean GetSyncAttrib(EGLDisplay dpy, EGLSyncKHR sync, EGLint attribute, EGLA`
`1417`	`1417`	`return error(EGL_BAD_PARAMETER, EGL_FALSE);`
`1418`	`1418`	`}`
`1419`	`1419`
	`1420`	`+ if(!value)`
	`1421`	`+ {`
	`1422`	`+ return error(EGL_BAD_PARAMETER, EGL_FALSE);`
	`1423`	`+ }`
	`1424`	`+`
`1420`	`1425`	`switch(attribute)`
`1421`	`1426`	`{`
`1422`	`1427`	`case EGL_SYNC_TYPE_KHR:`