Fix test failures that started appearing after package:vm_service was updated to 14.2.5 #8203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… updated to 14.2.5
Member
|
@bkonyi After this has landed, can you revert flutter/tests#397 and bump the devtools hash in there to pick up this change here please? |
packages/devtools_app_shared/lib/src/service/service_extension_manager.dart
Outdated
Show resolved
Hide resolved
Member
|
Looks like the goldens will need to be updated: Also, the new version of Flutter may have triggered the failure you are seeing on the benchmark-performance CI job. |
kenzieschmoll
approved these changes
Aug 19, 2024
…s_after_vm_service_14.2.5
Member
|
closing in favor of #8224, which patches in the changes from this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These failures are blocking the Flutter customer tests.