Skip to content

Handle breaking changes in package:vm_service v14 #6953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
derekxu16 merged 8 commits into from
Feb 2, 2024
Merged

Handle breaking changes in package:vm_service v14 #6953

derekxu16 merged 8 commits into from
Feb 2, 2024

Conversation

@derekxu16
Copy link
Contributor

@derekxu16 derekxu16 commented Dec 12, 2023

package:vm_service v14 includes breaking changes to the dart:io service extensions. This PR updates the package:vm_service constraint to ^14.0.0 and updates DevTools in response to those changes.

@bkonyi bkonyi mentioned this pull request Jan 4, 2024
Closed
8 tasks
@derekxu16 derekxu16 force-pushed the handle-changes-in-pkg-vm-service branch from bddf37f to 8f3fb23 Compare January 8, 2024 16:09
@kenzieschmoll kenzieschmoll mentioned this pull request Jan 16, 2024
Merged
@derekxu16 derekxu16 force-pushed the handle-changes-in-pkg-vm-service branch from 8f3fb23 to e231f34 Compare January 16, 2024 21:10
@derekxu16 derekxu16 marked this pull request as ready for review January 16, 2024 21:11
@derekxu16 derekxu16 requested review from a team, bkonyi and kenzieschmoll as code owners January 16, 2024 21:11
kenzieschmoll
kenzieschmoll reviewed Jan 16, 2024
View reviewed changes
kenzieschmoll
kenzieschmoll approved these changes Jan 16, 2024
View reviewed changes
Copy link
Member

@kenzieschmoll kenzieschmoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one request to de-dupe. then lgtm

bkonyi
bkonyi approved these changes Jan 17, 2024
View reviewed changes
@derekxu16 derekxu16 force-pushed the handle-changes-in-pkg-vm-service branch from fac7642 to 2d158f8 Compare January 18, 2024 15:42
@derekxu16 derekxu16 force-pushed the handle-changes-in-pkg-vm-service branch 2 times, most recently from 8f67165 to a488936 Compare January 31, 2024 17:21
@christopherfujino
Copy link
Contributor

christopherfujino commented Feb 1, 2024

@derekxu16 I rolled vm_service 14 to flutter/flutter in flutter/flutter#141427

@christopherfujino christopherfujino mentioned this pull request Feb 1, 2024
Closed
@derekxu16 derekxu16 force-pushed the handle-changes-in-pkg-vm-service branch 2 times, most recently from 565eebb to 3d8b718 Compare February 1, 2024 19:18
@derekxu16
Copy link
Contributor Author

derekxu16 commented Feb 1, 2024

@derekxu16 I rolled vm_service 14 to flutter/flutter in flutter/flutter#141427

Thanks!

christopherfujino
christopherfujino reviewed Feb 1, 2024
View reviewed changes
@derekxu16 derekxu16 force-pushed the handle-changes-in-pkg-vm-service branch from 3d8b718 to c813f7a Compare February 2, 2024 20:30
@derekxu16
Copy link
Contributor Author

derekxu16 commented Feb 2, 2024 •
edited
Loading

There is currently a mismatch between the layout of the data sent by the VM and the layout of data expected by package:vm_service 14.0.0. This is because I can't land the corresponding VM change (https://dart-review.googlesource.com/c/sdk/+/341120) without updating DevTools and rolling it internally first, or else I will break dart-cbuild.

The problem described above actually didn't apply, I just needed to change a call in NetworkController from service.socketProfilingEnabledWrapper to service.socketProfilingEnabled.

@derekxu16 derekxu16 force-pushed the handle-changes-in-pkg-vm-service branch from 20ca33c to 6d96471 Compare February 2, 2024 21:51
@derekxu16 derekxu16 force-pushed the handle-changes-in-pkg-vm-service branch from 6d96471 to 59b31d6 Compare February 2, 2024 22:04
@derekxu16 derekxu16 merged commit 3b610d9 into flutter:master Feb 2, 2024
@derekxu16 derekxu16 deleted the handle-changes-in-pkg-vm-service branch February 2, 2024 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kenzieschmoll kenzieschmoll kenzieschmoll approved these changes

@bkonyi bkonyi bkonyi approved these changes

+1 more reviewer

@christopherfujino christopherfujino christopherfujino left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@derekxu16 @christopherfujino @bkonyi @kenzieschmoll