Skip to content

inspector_service_test.dart: disable "widget tree" test #6903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bartekpacia merged 1 commit into from
Dec 9, 2023
Merged

inspector_service_test.dart: disable "widget tree" test #6903

bartekpacia merged 1 commit into from
Dec 9, 2023

Conversation

@bartekpacia
Copy link
Member

@bartekpacia bartekpacia commented Dec 6, 2023

This test must be disabled because it started giving false positives for

See also discussion on Discord about skipping this test.

See also issue that tracks re-enabling this test: #6902

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read the [Flutter Style Guide] recently, and have followed its advice.
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or there is a reason for not adding tests.

![build.yaml badge]

@bartekpacia bartekpacia mentioned this pull request Dec 6, 2023
Closed
kenzieschmoll
kenzieschmoll approved these changes Dec 6, 2023
View reviewed changes
Copy link
Member

@kenzieschmoll kenzieschmoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We can land this once the Google Testing check is green on your Flutter PR flutter/flutter#138331

@bartekpacia
Copy link
Member Author

bartekpacia commented Dec 6, 2023 •
edited
Loading

Thanks!
Chun Htai said in this Discord message that Google testing is red because the new engine hasn't yet rolled into Google internal testing and that it may take up to a week. So I guess we just wait for it.

@kenzieschmoll
Copy link
Member

kenzieschmoll commented Dec 6, 2023

Chun Htai said in this Discord message that Google testing is red because the new engine hasn't yet rolled into Google internal testing and that it may take up to a week. So I guess we just wait for it.

The google testing check will block you from submitting your Flutter PR (@chunhtai can confirm), so it is best to wait on disabling this test until everything else on your Flutter PR is green. Otherwise we will have this unnecessarily disabled while we want for the new engine to roll.

@bartekpacia
Copy link
Member Author

bartekpacia commented Dec 9, 2023

Google testing is green on flutter/flutter#138331, mergin this PR

@bartekpacia bartekpacia merged commit 14aa44e into flutter:master Dec 9, 2023
@bartekpacia bartekpacia deleted the test/exclude_false_positive branch December 9, 2023 00:26
derekxu16 pushed a commit to derekxu16/devtools that referenced this pull request Dec 14, 2023
@bartekpacia @derekxu16
inspector_service_test.dart: disable "widget tree" test (flutter#6903)
50e6735
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kenzieschmoll kenzieschmoll kenzieschmoll approved these changes

@CoderDake CoderDake Awaiting requested review from CoderDake

Assignees

No one assigned

Labels

release-notes-not-required

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bartekpacia @kenzieschmoll