Skip to content

Delete inspector polyfill logic #4633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kenzieschmoll merged 3 commits into from
Nov 14, 2022
Merged

Delete inspector polyfill logic #4633

kenzieschmoll merged 3 commits into from
Nov 14, 2022

Conversation

@kenzieschmoll
Copy link
Member

@kenzieschmoll kenzieschmoll commented Oct 21, 2022 •
edited
Loading

Fixes #4633. Requires flutter/flutter#113861 to land and roll into a flutter-candidate-* branch before we can land this PR.

@kenzieschmoll kenzieschmoll mentioned this pull request Oct 21, 2022
Merged
@kenzieschmoll kenzieschmoll mentioned this pull request Nov 1, 2022
Merged
@jacob314
Copy link
Contributor

jacob314 commented Nov 11, 2022

Can this be landed now? Would be great to get rid of the polyfill now that our version is tied to Flutter.
One thing we might want to do is actively fail at startup if you happen to use DevTools with an incompatible version of Flutter. That could happen if someone launched DevTools from one Flutter SDK and connected to a Flutter app from a different Flutter SDK. With this and similar changes we will start mysteriously failing when this happens. Users will assume DevTools is flaky rather than understanding they used an incompatible Flutter unless we warn them.

@kenzieschmoll
Copy link
Member Author

kenzieschmoll commented Nov 14, 2022

yes this can be landed now. I've been waiting for flutter/flutter#113861 to roll into google3, which looks like just happened friday afternoon.

@kenzieschmoll kenzieschmoll marked this pull request as ready for review November 14, 2022 16:40
@kenzieschmoll kenzieschmoll requested a review from a team as a code owner November 14, 2022 16:40
@kenzieschmoll kenzieschmoll requested review from bkonyi and removed request for a team November 14, 2022 16:40
@kenzieschmoll
Copy link
Member Author

kenzieschmoll commented Nov 14, 2022

Filed #4734 to track warning users for flutter version incompatibility

@kenzieschmoll kenzieschmoll merged commit 4306acd into flutter:master Nov 14, 2022
@kenzieschmoll kenzieschmoll deleted the polyfill branch November 14, 2022 17:12
@jacob314
Copy link
Contributor

jacob314 commented Nov 14, 2022

Fyi @annagrin and @elliette. This should significantly speedup Flutter Web inspector startup as we won't be doing evals as part of the initial load.

@kenzieschmoll kenzieschmoll mentioned this pull request Feb 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bkonyi bkonyi bkonyi approved these changes

+1 more reviewer

@CoderDake CoderDake CoderDake approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kenzieschmoll @jacob314 @CoderDake @bkonyi