Thinking about this some more, I realize we only looked at half the issue and weren't accounting for the places where devtools itself calls out to sub-tools (and should in turn flow env variables down to them).

Gemini did a round-up for me (included below). A bunch can be ignored (for example shell commands and test infrastructure) but we should look at the flutter tool calls ay least.

Spawning in Production Code

DeeplinkManager
- File: packages/devtools_shared/lib/src/deeplink/deeplink_manager.dart
- Line reference: deeplink_manager.dart#L48
- Details: Spawns flutter binary via Process.run to analyze deep links (e.g., --list-build-variants, --output-app-link-settings, --list-build-options).

Spawning in DevTools Extension Building / Tooling

BuildExtensionCommand
- File: packages/devtools_extensions/bin/_build_and_copy.dart
- Line reference: _build_and_copy.dart#L125
- Details: Spawns flutter build web and chmod via ProcessManager when preparing/packaging extensions.
Rollback Command
- File: tool/lib/commands/rollback.dart
- Details: Spawns tar via Process.run to handle rollbacks.
Release Helper Command
- File: tool/lib/commands/release_helper.dart
- Details: Spawns git commands.
Model and General Script Utilities
- Files: tool/lib/model.dart & tool/lib/utils.dart
- Details: Spawns commands like which flutter and other scripting subprocesses.

Spawning in Test Infrastructure

Chrome & Chromedriver
- Files:
  - packages/devtools_shared/lib/src/test/chrome.dart (Starts Chrome browser)
  - packages/devtools_shared/lib/src/test/chrome_driver.dart (Starts Chromedriver)
Integration & CLI Test Runners
- Files:
  - packages/devtools_shared/lib/src/test/integration_test_runner.dart
  - packages/devtools_shared/lib/src/test/cli_test_driver.dart
Mock / Helper Spawners in tests
- Files:
  - packages/devtools_shared/test/helpers/helpers.dart (Starts DTD test instances)
  - packages/devtools_shared/test/helpers/extension_test_manager.dart
  - packages/devtools_app/test/test_infra/flutter_test_driver.dart (Starts Flutter test driver processes)
  - packages/devtools_app/integration_test/test_infra/run/run_test.dart (Starts DevTools server for integration tests)
  - packages/devtools_app/integration_test/test_infra/run/_test_app_driver.dart

Uh oh!

[analytics] Update devtools to set analytics ENV variables when invoking sub-tools #9702

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions