Skip to content

Reset Dashboard Checks to In Progress when re-run all failed jobs - #5130

Merged
auto-submit[bot] merged 3 commits into
flutter:mainfrom
ievdokdm:191005-re-request-2
Aug 19, 2026
Merged

Reset Dashboard Checks to In Progress when re-run all failed jobs#5130
auto-submit[bot] merged 3 commits into
flutter:mainfrom
ievdokdm:191005-re-request-2

Conversation

@ievdokdm

@ievdokdm ievdokdm commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

fix of the github error:

Error:
    GitHub Error: 
      Message: Invalid request.
    
    For 'properties/name', nil is not a string.
     is not a member of ["success", "failure", "neutral", "cancelled", "timed_out", "action_required", "skipped"].
    For 'properties/conclusion', nil is not a string.
    For 'properties/completed_at', nil is not a string.

when reset check run status back to in progress

in scope of: flutter/flutter#191005

@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Aug 19, 2026
@ievdokdm
ievdokdm requested a review from jtmcdole August 19, 2026 19:57
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Aug 19, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the GitHub checks utility by removing the custom resetCheckRun method and replacing its usage with the standard updateCheckRun method. However, the reviewer identified a semantic issue where conclusion: CheckRunConclusion.neutral is set alongside status: CheckRunStatus.inProgress. In the GitHub Checks API, a check run cannot be in progress and have a completed conclusion simultaneously. The reviewer suggests removing the conclusion parameter from the updateCheckRun call and updating the corresponding unit tests to match this corrected behavior.

Comment thread app_dart/lib/src/service/luci_build_service.dart Resolved
Comment thread app_dart/test/service/luci_build_service/schedule_try_builds_test.dart Resolved
Comment thread app_dart/test/service/luci_build_service/schedule_try_builds_test.dart Resolved
@ievdokdm ievdokdm changed the title attemt to fix github error Reset Dashboard Checks to In Progress when re-run all failed jobs Aug 19, 2026
@ievdokdm ievdokdm added the autosubmit Merge PR when tree becomes green via auto submit App. label Aug 19, 2026
@auto-submit
auto-submit Bot merged commit 80b2cb4 into flutter:main Aug 19, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jtmcdole jtmcdole jtmcdole approved these changes
+1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App. CICD Run CI/CD

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ievdokdm @jtmcdole