Skip to content

Commit bc221aa

Browse files
authored
reset re-runned dashboard checks conclusion to neutral (#5136)
workaround for flutter/flutter#191005
1 parent a68a8c6 commit bc221aa

2 files changed

Lines changed: 5 additions & 5 deletions

File tree

‎app_dart/lib/src/service/scheduler.dart‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1716,13 +1716,13 @@ $stacktrace
17161716
case Config.kDashboardCheckName:
17171717
try {
17181718
log.info(
1719-
'Resetting dashboard checks ${checkRunEvent.checkRun!.id} to queued',
1719+
'Resetting dashboard checks ${checkRunEvent.checkRun!.id} to neutral',
17201720
);
17211721
await _githubChecksService.githubChecksUtil.updateCheckRun(
17221722
_config,
17231723
slug,
17241724
checkRunEvent.checkRun!.toGithubCheckRun(),
1725-
status: CheckRunStatus.queued,
1725+
conclusion: CheckRunConclusion.neutral,
17261726
output: const CheckRunOutput(
17271727
title: Config.kDashboardCheckName,
17281728
summary: Scheduler.kDashboardChecksDescription,
@@ -1732,7 +1732,7 @@ $stacktrace
17321732
} catch (e, s) {
17331733
// We are not going to block on this error.
17341734
log.warn(
1735-
'Failed to reset dashboard checks ${checkRunEvent.checkRun!.id} to queued',
1735+
'Failed to reset dashboard checks ${checkRunEvent.checkRun!.id} to neutral',
17361736
e,
17371737
s,
17381738
);

‎app_dart/test/service/scheduler_test.dart‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1050,7 +1050,7 @@ void main() {
10501050
verifyNever(mockGithubChecksUtil.createCheckRun(any, any, any, any));
10511051
});
10521052

1053-
test('rerequested dashboard check resets check run to queued', () async {
1053+
test('rerequested dashboard check resets check run to neutral', () async {
10541054
final mockGithubService = MockGithubService();
10551055
final mockGithubClient = MockGitHub();
10561056
config = FakeConfig(githubService: mockGithubService);
@@ -1089,7 +1089,7 @@ void main() {
10891089
any,
10901090
RepositorySlug.full('flutter/cocoon'),
10911091
any,
1092-
status: CheckRunStatus.queued,
1092+
conclusion: CheckRunConclusion.neutral,
10931093
output: const CheckRunOutput(
10941094
title: Config.kDashboardCheckName,
10951095
summary: Scheduler.kDashboardChecksDescription,

0 commit comments

Comments
 (0)