Skip to content

Conversation

@ivirtex
Copy link
Contributor

@ivirtex ivirtex commented Mar 21, 2023

This PR adds diagram of Curves.fastEaseInToSlowEaseOut as part of flutter/flutter#122275

curve_fast_ease_in_to_slow_ease_out.mp4

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read the [Flutter Style Guide] recently, and have followed its advice.
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@ivirtex
Copy link
Contributor Author

ivirtex commented May 10, 2023

@MitchellGoodwin, I think this can be merged now, since changes just landed on stable.

@MitchellGoodwin
Copy link

@MitchellGoodwin, I think this can be merged now, since changes just landed on stable.

Yes, I'm not sure if the checks pick it up right away, but it should be good to go. Can you rebase to restart the tests?

@ivirtex
Copy link
Contributor Author

ivirtex commented May 10, 2023

I think they fail because Flutter 3.10 uses Dart 3 which doesn't allow unsound null safety and some of the codebase here is written without null safety - thus preventing tests from using latest stable?
Though, I am not sure if that's the case.

@ivirtex
Copy link
Contributor Author

ivirtex commented May 13, 2023

Ok, I think I found the issue, .cirrus.yml specifies to use dev Flutter channel for CI, which has been retired.
I changed it to master, but this caused a whole chain of problems:

  1. flutter format has been deprecated and insists on using dart format, this requires bumping flutter_plugin_tools version to at least 0.13.2+1.
  2. The new version of flutter_plugin_tools complains about formatting in several files, missing license and incorrect pubspec.yaml in one of the packages.
  3. On Flutter 3.10 ui.window is deprecated, so ~40 lines of code need to be migrated to the new API.
  4. Several constructors are missing const keyword, but that's an easy fix with dart fix.
  5. Several lines must be modified to enable full sound null safety.

I created a draft PR addressing most of these issues: #215

@MitchellGoodwin
Copy link

@ivirtex can you rebase to see if the update to 3.0 fixes the tests?

@MitchellGoodwin
Copy link

Looks like it passes the tests, but also it needs to have it's head changed to 'main' instead of 'master_archived'

@ivirtex ivirtex changed the base branch from master_archived to main May 31, 2023 20:04
Copy link

@MitchellGoodwin MitchellGoodwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you very much!

@ivirtex
Copy link
Contributor Author

ivirtex commented Jun 8, 2023

@MitchellGoodwin Thanks for reviewing. I can't merge by myself, so I think you, or someone else, must merge this PR manually.

@MitchellGoodwin MitchellGoodwin merged commit 01084ce into flutter:main Jun 12, 2023
@ivirtex ivirtex deleted the add-new-curve branch June 13, 2023 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants