-
Notifications
You must be signed in to change notification settings - Fork 110
Add diagram of Curves.fastEaseInToSlowEaseOut
#211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@MitchellGoodwin, I think this can be merged now, since changes just landed on stable. |
Yes, I'm not sure if the checks pick it up right away, but it should be good to go. Can you rebase to restart the tests? |
|
I think they fail because Flutter 3.10 uses Dart 3 which doesn't allow unsound null safety and some of the codebase here is written without null safety - thus preventing tests from using latest stable? |
|
Ok, I think I found the issue, .cirrus.yml specifies to use
I created a draft PR addressing most of these issues: #215 |
|
@ivirtex can you rebase to see if the update to 3.0 fixes the tests? |
|
Looks like it passes the tests, but also it needs to have it's head changed to 'main' instead of 'master_archived' |
MitchellGoodwin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you very much!
|
@MitchellGoodwin Thanks for reviewing. I can't merge by myself, so I think you, or someone else, must merge this PR manually. |
c8a04fb to
c637b8c
Compare
This PR adds diagram of
Curves.fastEaseInToSlowEaseOutas part of flutter/flutter#122275curve_fast_ease_in_to_slow_ease_out.mp4
Pre-launch Checklist
///).