Add the cupertino system colors mint, cyan, and brown #207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
Contributor
Author
|
The CI failing is expected as the PR only compiles with the changes from flutter/flutter#118971. |
|
This PR is going to need to wait until the updated colors are in stable before it's merged. |
Contributor
|
It's been about three months since our last stable so the next stable should be soon! |
|
@paldepind Hello 👋. The updated colors are in stable now, so would you mind rebasing to restart the tests? |
|
@paldepind the base branch was changed from |
|
I've updated the target branch and brought the PR up to date. Going off the previous CI results the code may still require formatting. |
MitchellGoodwin
approved these changes
Jun 1, 2023
MitchellGoodwin
left a comment
MitchellGoodwin
left a comment
There was a problem hiding this comment.
LGTM. Thank you for putting this together.
Contributor
Author
|
Thanks @domesticmouse 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Cupertino system colors figure with the missing colors mint, cyan and brown as mentioned in flutter/flutter#118970 and as added in the PR flutter/flutter#118971.
I also changed the ordering of the colors to match the order they have in the Apple HIG. This order sorts the colors based on their position in the color wheel (I think) and is much more visually pleasing.
With the three extra colors, the figure did not fit in the viewport available for the diagrams. I henced increased its size a bit in order to fit the figure.
Note the that this PR depends on flutter/flutter#118971 as it uses the new colors added there. Hence it should only be merged after that.
Pre-launch Checklist
///).