Skip to content

Add CupertinoColors color palette diagrams #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TahaTesser merged 1 commit into from
May 17, 2022
Merged

Add CupertinoColors color palette diagrams #183

TahaTesser merged 1 commit into from
May 17, 2022

Conversation

@TahaTesser
Copy link
Member

@TahaTesser TahaTesser commented May 7, 2022

part of flutter/flutter#72926

Required for flutter/flutter#103280

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@TahaTesser TahaTesser mentioned this pull request May 7, 2022
Merged
8 tasks
@TahaTesser TahaTesser requested a review from guidezpl May 7, 2022 21:21
guidezpl
guidezpl requested changes May 9, 2022
View reviewed changes
@guidezpl
Copy link
Member

guidezpl commented May 9, 2022

Please make sure we're including all relevant colors. Those which adapt, e.g. systemGreen should be in their own section

@TahaTesser
Copy link
Member Author

TahaTesser commented May 9, 2022

Please make sure we're including all relevant colors. Those which adapt, e.g. systemGreen should be in their own section

Added missing colors and organized the colors into different sections, preview here

@TahaTesser TahaTesser requested a review from guidezpl May 9, 2022 12:22
guidezpl
guidezpl reviewed May 9, 2022
View reviewed changes
Copy link
Member

@guidezpl guidezpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious why assets/cupertino/cupertino_background_colors.png is wider than the others?

@guidezpl
Copy link
Member

guidezpl commented May 9, 2022

Small nit: I'd put the two separators in system 3 colors

guidezpl
guidezpl reviewed May 9, 2022
View reviewed changes
guidezpl
guidezpl reviewed May 9, 2022
View reviewed changes
@TahaTesser
Copy link
Member Author

TahaTesser commented May 10, 2022

Curious why assets/cupertino/cupertino_background_colors.png is wider than the others?

Background colors have long titles so I made this wider for easier reading.

@TahaTesser TahaTesser requested a review from guidezpl May 13, 2022 08:30
@guidezpl
Copy link
Member

guidezpl commented May 16, 2022

Curious why assets/cupertino/cupertino_background_colors.png is wider than the others?

Background colors have long titles so I made this wider for easier reading.

Could we just make that first column wider and keep the rest neat and tight?

@TahaTesser
Copy link
Member Author

TahaTesser commented May 17, 2022

Could we just make that first column wider and keep the rest neat and tight?

Just updated

@guidezpl
Copy link
Member

guidezpl commented May 17, 2022

Perfect, looks great!

@TahaTesser
Add CupertinoColors color palette diagrams
4dc04b8 
Fix analyzer issues

fix format

Updates from review

Update diagrams

Update background colors diagram
@TahaTesser TahaTesser force-pushed the cupertino_colors_diagrams branch from 71b5c2e to 4dc04b8 Compare May 17, 2022 11:32
@TahaTesser TahaTesser merged commit 4ab6b74 into flutter:master May 17, 2022
@TahaTesser TahaTesser deleted the cupertino_colors_diagrams branch May 17, 2022 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@guidezpl guidezpl guidezpl approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TahaTesser @guidezpl