Repository navigation
Conversation
Piinks
left a comment
There was a problem hiding this comment.
Apologies for the delay! More awesome stuff! 🎉
|
Thanks so much for the review! Apologies for the inconvenience, but I started a vacation and I'm out until October 7th. I'll certainly update this PR when I'm back in action :) |
No inconvenience at all! Enjoy your vacation! 🏖 |
…ry configuration widgets
… necessary configuration widgets" This reverts commit 12ef635.
that includes a `navigator` option for `showDialog`, `showDatePicker`, and `showGenericDialog`.
|
Hey! I saw flutter/flutter#42842 was merged in! 🎉 |
|
Hi @Piinks! Yep, I think this one is mostly good to go, but with one question: What kind of extra labels do you think would be good to add to the SingleChildScrolLView diagrams? I've read through the github issue, linked twitter thread and sample github repo, but I couldn't quite think of the kind of diagrams or animations (mentioned by Ian) that might be helpful to add here that would address the underlying issue -- which seemed more related to SliverFillRemaining. I can certainly add an |
An app bar sounds like a good idea. Perhaps also, we can just add text that labels each box with its associated widget from the composition? WDYT? |
|
Sounds good! Since the documentation references "fixed height" vs "expanded" content sections I've used those terms to label the boxes. Please let me know if those terms work or if you'd like me to use the name Widget itself, such as "Fixed Height Container" Other than that, I'll watch the build to make sure it passes, and should be good for a final review :) |
Piinks
left a comment
There was a problem hiding this comment.
LGTM!
Thanks for addressing the breaking change in image.dart! 🎉
Heya @Piinks -- another set of Diagrams for your review when you have time!
This set includes: