Skip to content

update link to good first issues #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
andrewkolos merged 1 commit into from
Jul 17, 2023
Merged

update link to good first issues #28

andrewkolos merged 1 commit into from
Jul 17, 2023

Conversation

@andrewkolos
Copy link
Contributor

@andrewkolos andrewkolos commented Jul 17, 2023

Copy-pasted from flutter/flutter#130759:

Today (Jul 17, 2023), I renamed the good first contribution label to good first issue. This is because

  1. good first issue is the more commonly used for this intent and may be (ever so slightly) more recognizable to potential new contributors, and, more importantly,
  2. GitHub recognizes the label good first issue when surfacing good first issues in specific places in GitHub1.

This PR updates Contributing.md to match the new name.

grep did not find any other references to good first contribution to update in this repo.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above. (not applicable in my opinion. If you'd like me to file an issue first, let me know what label would be appropriate.)
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt. not applicable: docs-only change
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Footnotes

  1. Source (GitHub docs). Example: https://github.com/flutter/flutter/contribute. If my vague memory serves me correctly, this can also appear in certain emails or the "discovery queue"-type experience that GitHub provides. ↩

@andrewkolos andrewkolos requested a review from Hixie July 17, 2023 22:39
Hixie
Hixie approved these changes Jul 17, 2023
View reviewed changes
Copy link
Contributor

@Hixie Hixie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewkolos
Copy link
Contributor Author

andrewkolos commented Jul 17, 2023

Force push was to re-add the same commit (signed this time).

@andrewkolos andrewkolos merged commit 231e1d3 into flutter:main Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Hixie Hixie Hixie approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@andrewkolos @Hixie