adding bonus to roll_MdN#935
Merged
thefallentree merged 3 commits intofluffos:masterfrom Nov 19, 2022
gesslar:adding-bonus-to-roll_MdN
Merged
adding bonus to roll_MdN#935thefallentree merged 3 commits intofluffos:masterfrom gesslar:adding-bonus-to-roll_MdN
thefallentree merged 3 commits intofluffos:masterfrom
gesslar:adding-bonus-to-roll_MdN
Conversation
Member
|
On second thought: do we want to implement this in the efun? Or could this be a simple stdlib thing |
Contributor
Author
|
roll_MdN is already an efun. to implement these as stdlib would require
that everybody has the same configuration for valid_override, which is
doubtful. unless you want a breaking change and remove roll_MdN.
this modification makes the existing efun more complete.
Brian M. Workman
***@***.***
…On Sat, Nov 19, 2022 at 3:40 AM Yucong Sun ***@***.***> wrote:
On second thought: do we want to implement this in the efun? Or could this
be a simple stdlib thing
—
Reply to this email directly, view it on GitHub
<#935 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJVJ54TJWUP4CSGUP6GI2DWJCG7HANCNFSM6AAAAAASBR6LCI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
thefallentree
approved these changes
Nov 19, 2022
Amirani-al
pushed a commit
to Amirani-al/fluffos
that referenced
this pull request
May 30, 2023
* adding bonus to roll_MdN * properly using value of num_arg * bonus will only be applied if roll has ben performed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New third parameter, bonus, which will get added to the result of the roll(s), further simulating the rolling of dice as in TTRPGs.