Allowing '#' in file path for objects with OID. Fixes erroneous read access error in simulate.cc.#910
Merged
thefallentree merged 1 commit intofluffos:masterfrom Aug 27, 2022
Merged
Conversation
…access error in simulate.cc
Amirani-al
pushed a commit
to Amirani-al/fluffos
that referenced
this pull request
May 30, 2023
…access error in simulate.cc (fluffos#910)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes erroneous error "Read access denied" when using
load_object()on a file path containing an OID for an object that has been destructed. The error now correctly states "Cannot load a clone."load_object()in simulate.cc already contained logic to disallow '#' for clones which generates appropriate error messaging. This was never being hit due to how '#' was being handled inlegal_path()