Skip to content

Allowing '#' in file path for objects with OID. Fixes erroneous read access error in simulate.cc.#910

Merged
thefallentree merged 1 commit intofluffos:masterfrom
jalbright015:master
Aug 27, 2022
Merged

Allowing '#' in file path for objects with OID. Fixes erroneous read access error in simulate.cc.#910
thefallentree merged 1 commit intofluffos:masterfrom
jalbright015:master

Conversation

@jalbright015
Copy link
Copy Markdown
Contributor

@jalbright015 jalbright015 commented Aug 27, 2022

Fixes erroneous error "Read access denied" when using load_object() on a file path containing an OID for an object that has been destructed. The error now correctly states "Cannot load a clone."

base/internal/file.cc->legal_path()              // <-- This would return 0
src/packages/core/file.cc->check_valid_path()    // <-- Causing this to return 0
vm/internal/simulate.cc->load_object()           // <-- Causing this to return 'Read access denied."

load_object() in simulate.cc already contained logic to disallow '#' for clones which generates appropriate error messaging. This was never being hit due to how '#' was being handled in legal_path()

@thefallentree thefallentree merged commit 8d0801e into fluffos:master Aug 27, 2022
Amirani-al pushed a commit to Amirani-al/fluffos that referenced this pull request May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants