Skip to content

add docker build and publish#817

Merged
thefallentree merged 4 commits intofluffos:masterfrom
lostsnow:feature/action-docker
Jun 23, 2021
Merged

add docker build and publish#817
thefallentree merged 4 commits intofluffos:masterfrom
lostsnow:feature/action-docker

Conversation

@lostsnow
Copy link
Copy Markdown
Contributor

Docker image will publish to ghcr.io/fluffos/fluffos

branches: [ master ]
paths-ignore:
- 'docs/**'
pull_request:
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we probably should not run on pull_request,

but we could run on new releases

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already changed, but we can't find the docker build failure when pull request

with:
registry: ${{ env.REGISTRY }}
username: ${{ github.actor }}
password: ${{ secrets.GITHUB_TOKEN }}
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the TOKEN here?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thefallentree thefallentree merged commit 63292d3 into fluffos:master Jun 23, 2021
Amirani-al pushed a commit to Amirani-al/fluffos that referenced this pull request May 30, 2023
* add dockerfile and github action

* github action version

* update dockerfile for code analysis

* change github action docker trigger
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants