Skip to content

adding new efun: telnet_ga() to send go ahead telnet message sequence#815

Merged
thefallentree merged 1 commit intofluffos:masterfrom
gesslar:adding-f_telnet_ga
Jun 5, 2021
Merged

adding new efun: telnet_ga() to send go ahead telnet message sequence#815
thefallentree merged 1 commit intofluffos:masterfrom
gesslar:adding-f_telnet_ga

Conversation

@gesslar
Copy link
Copy Markdown
Contributor

@gesslar gesslar commented Jun 5, 2021

The only thing I would like to mention is that, not only f_telnet_ga(), but f_telnet_nop() send a debug_message BEFORE sending the codes.

void f_telnet_nop() {
  auto ip = current_object->interactive;
  if (ip && ip->telnet) {
    telnet_send_nop(ip->telnet);
    flush_message(ip);
  } else if (!ip) {
    debug_message("Warning: wrong usage. telnet_nop() should only be called by a user object.\n");
  }
}

The debug message gets executed before the telnet_send. Happens with other, related efuns as well. So that's a mystery that I am not equipped to solve, but maybe someone else can?

@thefallentree thefallentree merged commit d04c15d into fluffos:master Jun 5, 2021
@gesslar gesslar deleted the adding-f_telnet_ga branch June 6, 2021 00:22
Amirani-al pushed a commit to Amirani-al/fluffos that referenced this pull request May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants