load_object: fix buffer overruns.#796
Merged
thefallentree merged 2 commits intofluffos:masterfrom Apr 19, 2021
Merged
Conversation
`real_name` and `obname` are the same size as `name` and `actualname`. This means that if `lname` is 400 or more characters long, `actualname` and `obname` will be filled and the `strcat` calls to append `".c"` to `real_name` and `obname` will result in buffer overruns. Extend `real_name` and `obname` to make room for `".c"`. Signed-off-by: Jeremy Sowden <[email protected]>
Amirani-al
pushed a commit
to Amirani-al/fluffos
that referenced
this pull request
May 30, 2023
* load_object: fix buffer overruns. `real_name` and `obname` are the same size as `name` and `actualname`. This means that if `lname` is 400 or more characters long, `actualname` and `obname` will be filled and the `strcat` calls to append `".c"` to `real_name` and `obname` will result in buffer overruns. Extend `real_name` and `obname` to make room for `".c"`. Signed-off-by: Jeremy Sowden <[email protected]> * Update src/vm/internal/simulate.cc Co-authored-by: Yucong Sun <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
real_nameandobnameare the same size asnameandactualname.This means that if
lnameis 400 or more characters long,actualnameand
obnamewill be filled and thestrcatcalls to append".c"toreal_nameandobnamewill result in buffer overruns.Extend
real_nameandobnameto make room for".c".Signed-off-by: Jeremy Sowden [email protected]