Ignore NUnit1034 warning to make Postgres11_0IndexTests abstract#2207
Merged
Conversation
Co-authored-by: jzabroski <[email protected]>
Copilot
AI
changed the title
[WIP] Fix NUnit1034 warning for Postgres11_0IndexTests
Make Postgres11_0IndexTests abstract to fix NUnit1034 warning
Dec 3, 2025
Collaborator
|
@copilot Look again. The likely right fix is to silence this warning as a false positive, as Postgres11_0IndexTests provides actual tests to execute that are also run by Postgres15_0IndexTests. If there is an alternative way to code such tests with NUnit let's discuss |
…abstract The Postgres11_0IndexTests class contains actual test methods that should run for Postgres 11.0. Making it abstract would prevent these tests from running. Instead, suppress the warning using #pragma since this is a valid use case. Co-authored-by: jzabroski <[email protected]>
Contributor
Author
You're right. Changed approach to suppress the NUnit1034 warning with |
jzabroski
marked this pull request as ready for review
December 3, 2025 03:46
jzabroski
changed the title
This was referenced Jan 15, 2026
This was referenced Jan 30, 2026
This was referenced Feb 15, 2026
This was referenced Mar 1, 2026
This was referenced Mar 15, 2026
Merged
This was referenced Jun 8, 2026
This was referenced Jun 22, 2026
This was referenced Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changed approach from making
Postgres11_0IndexTestsabstract to suppressing the NUnit1034 warning with#pragma warning disable.The class contains actual test methods (
CanCreateIndexAsOnly,CanCreateIndexWithVacuumCleanupIndexScaleFactor) that should execute when testing Postgres 11.0. Making it abstract would prevent these tests from running directly on the Postgres11_0 generator.Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.