Skip to content

Refactor: Update ColumnBase to use generic type and fix deprecation w…#2193

Merged
jzabroski merged 2 commits into
mainfrom
feature/fix-deprecation-warnings
Dec 2, 2025
Merged

Refactor: Update ColumnBase to use generic type and fix deprecation w…#2193
jzabroski merged 2 commits into
mainfrom
feature/fix-deprecation-warnings

Conversation

@PhenX

@PhenX PhenX commented Nov 22, 2025

Copy link
Copy Markdown
Collaborator

…arnings

@PhenX
PhenX requested a review from jzabroski as a code owner November 22, 2025 11:03
@github-actions

github-actions Bot commented Nov 22, 2025

Copy link
Copy Markdown

Test Results

    2 files  ±0      2 suites  ±0   35s ⏱️ -4s
5 355 tests ±0  5 023 ✅ +1  332 💤 ±0  0 ❌  - 1 
5 836 runs  ±0  5 240 ✅ +1  596 💤 ±0  0 ❌  - 1 

Results for commit c5bacaa. ± Comparison against base commit fcc42a9.

♻️ This comment has been updated with latest results.

…n SymbolExtensions and move OptionName outside compile condition

@jzabroski jzabroski left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But my thought is we publish 7.2 without net10.0 support and publish 8.0 with net10.0 and this. Thoughts?

@PhenX

PhenX commented Nov 22, 2025

Copy link
Copy Markdown
Collaborator Author

@jzabroski 7.2 has so many changes that it could be 8.0 😅
But yeah, I'm ok with this

@jzabroski

Copy link
Copy Markdown
Collaborator

they're not really breaking changes, though. the ones that are, have been marked obsolete for almost a decade lol 😆

@jzabroski jzabroski added this to the 7.3.0 milestone Nov 22, 2025
@jzabroski
jzabroski merged commit 2c5ea04 into main Dec 2, 2025
4 checks passed
@jzabroski jzabroski removed this from the 8.0.0 milestone Dec 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants