Fix MySQL .AsTime() creating DATETIME column instead of TIME#2190
Merged
Conversation
Co-authored-by: jzabroski <[email protected]>
Copilot
AI
changed the title
[WIP] Fix MySql5 AsTime() to create TIME column instead of DATETIME
Fix MySQL .AsTime() creating DATETIME column instead of TIME
Nov 22, 2025
jzabroski
marked this pull request as ready for review
November 22, 2025 03:44
This was referenced Dec 2, 2025
This was referenced Dec 15, 2025
Closed
This was referenced Jan 30, 2026
This was referenced Feb 9, 2026
This was referenced Feb 13, 2026
This was referenced Mar 6, 2026
This was referenced Mar 21, 2026
This was referenced Jun 8, 2026
This was referenced Jun 15, 2026
This was referenced Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MySQL type map incorrectly mapped
DbType.TimetoDATETIMEinstead ofTIME, affecting all MySQL versions (4, 5, 8) since they inherit fromMySql4TypeMap.Changes
MySql4TypeMap.csline 115 from"DATETIME"to"TIME"MySql4TypeMapTests.cs,MySql5TypeMapTests.cs, andMySql8TypeMapTests.csto validate Time/Date/DateTime mappingsExample
Before:
CREATE TABLE MyTable (MyTimeColumn DATETIME)After:
CREATE TABLE MyTable (MyTimeColumn TIME)This aligns MySQL with PostgreSQL and other database generators that correctly map to native TIME types.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
6wovsblobprodsu6weus74.blob.core.windows.net/usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/fluentmigrator/.codeql-scratch/dbs/csharp/working/11554EEF5C921FE9659F6431188DBD4A/missingpackages_workingdir --packages /home/REDACTED/work/fluentmigrator/.codeql-scratch/dbs/csharp/working/missingpackages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal --configfile /home/REDACTED/work/fluentmigrator/.codeql-scratch/dbs/csharp/working/nugetconfig/nuget.config --force(dns block)aaevsblobprodsu6weus85.blob.core.windows.net/usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/fluentmigrator/.codeql-scratch/dbs/csharp/working/8AEA375C9885230658FAC60AC8549FD5/missingpackages_workingdir --packages /home/REDACTED/work/fluentmigrator/.codeql-scratch/dbs/csharp/working/missingpackages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal --configfile /home/REDACTED/work/fluentmigrator/.codeql-scratch/dbs/csharp/working/nugetconfig/nuget.config --force(dns block)/usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/fluentmigrator/.codeql-scratch/dbs/csharp/working/11554EEF5C921FE9659F6431188DBD4A/missingpackages_workingdir --packages /home/REDACTED/work/fluentmigrator/.codeql-scratch/dbs/csharp/working/missingpackages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal --configfile /home/REDACTED/work/fluentmigrator/.codeql-scratch/dbs/csharp/working/nugetconfig/nuget.config --force(dns block)l78vsblobprodsu6weus64.blob.core.windows.net/usr/bin/dotnet dotnet build FluentMigrator.sln -c Release(dns block)/usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/fluentmigrator/fluentmigrator/FluentMigrator.sln --packages /home/REDACTED/work/fluentmigrator/.codeql-scratch/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/home/REDACTED/work/fluentmigrator/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/home/REDACTED/work/fluentmigrator/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot(dns block)pyvvsblobprodsu6weus63.blob.core.windows.net/usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/fluentmigrator/fluentmigrator/FluentMigrator.sln --packages /home/REDACTED/work/fluentmigrator/.codeql-scratch/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/home/REDACTED/work/fluentmigrator/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/home/REDACTED/work/fluentmigrator/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.