Limit CI test targets by OS: run net8.0 on Linux and net48 on Windows only#2173
Merged
Merged
Conversation
spopp23
force-pushed
the
feature/fix_pr_workflow
branch
from
November 10, 2025 13:01
cfef7a6 to
678d672
Compare
Collaborator
|
I changed it slightly; honestly, the way this is done is not great, I just haven't had the bandwidth to clean it up. Going to make some progress this month in prep for Microsoft releasing .NET 10 tomorrow. |
Contributor
Author
|
Yeah, I just noticed. Thank you! I will close this PR then. |
Collaborator
|
We can still go with your approach as a base. |
…son resolves correctly
Collaborator
|
I was struggling to understand why this was still failing, and then I realized that its due to how I set-up permissions to prevent people from submitting PRs that change this file to execute Confused Deputy attacks and do things like potentially steal variables, viz a viz 'pull request targets' security feature of GitHub Actions. Will merge; think we are good here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Windows job in CI was failing due to running a net48 test target on Linux (see PR #2171).
PR #2162 appears to have introduced an extra test run (net8.0 on Windows) although discussion suggested net48 should be Windows-only.
What I changed
Linux runners now execute tests only for net8.0.
Windows runners now execute tests only for net48.
Why
According to the comments on PR #2162 .NET 8.0 is supposed to run on Linux only; running it on Windows is unnecessary and fails.
Keeps net8.0 coverage on Linux while preserving net48 coverage on Windows.
Impact
Green CI on Windows again.
No loss of coverage—just correct platform targeting.