Add IDictionary support to Update data expressions#2163
Merged
Conversation
Co-authored-by: jzabroski <[email protected]>
Copilot
AI
changed the title
[WIP] Make all data expressions IDictionary aware (like Row)
Add IDictionary support to Update data expressions
Sep 8, 2025
Collaborator
|
jzabroski
marked this pull request as ready for review
November 11, 2025 15:32
3 tasks
This was referenced Dec 2, 2025
This was referenced Dec 15, 2025
Closed
This was referenced Feb 9, 2026
This was referenced Mar 6, 2026
This was referenced Mar 21, 2026
This was referenced Jun 8, 2026
This was referenced Jun 15, 2026
This was referenced Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for
IDictionary<string, object>parameters to Update data expressions, bringing them in line with the existing Insert data expression functionality.Problem
Previously, Update expressions only accepted anonymous objects for
SetandWhereoperations:However, Insert expressions already supported both anonymous objects and IDictionary:
This inconsistency made it impossible to build dynamic Update statements where column names and values are determined at runtime.
Solution
This PR adds IDictionary overloads to the Update expression interfaces and implementation:
Changes Made
ExpressionBuilderBase.GetData- Added support forIDictionary<string, object>input directlyIUpdateSetSyntaxandIUpdateWhereSyntaxUpdateDataExpressionBuilderBenefits
GetDatamethodTesting
All changes are thoroughly tested with both new IDictionary functionality and existing anonymous object usage to ensure no regressions.
Fixes #981.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.