Enhance GitHub Actions to build on ubuntu-latest and windows-latest#2162
Merged
Conversation
…latest OS matrix Co-authored-by: jzabroski <[email protected]>
Copilot
AI
changed the title
[WIP] Enhance GitHub Actions to build on ubuntu-latest and windows-latesr
Enhance GitHub Actions to build on ubuntu-latest and windows-latest
Sep 7, 2025
jzabroski
approved these changes
Sep 7, 2025
Test Results 1 files 1 suites 33s ⏱️ Results for commit 187ce2a. ♻️ This comment has been updated with latest results. |
jzabroski
marked this pull request as ready for review
September 7, 2025 01:52
PhenX
approved these changes
Sep 7, 2025
| <PropertyGroup> | ||
| <TargetFramework Condition="'$(CI)' == 'true'">net8.0</TargetFramework> | ||
| <TargetFramework Condition="'$(CI)' == ''">net48</TargetFramework> | ||
| <TargetFramework Condition="$([MSBuild]::IsOSPlatform('Linux'))">net8.0</TargetFramework> |
Collaborator
There was a problem hiding this comment.
Yeah that's far better than what I did
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enhances the CI/CD pipeline to run tests on both Linux and Windows platforms, addressing the need for broader platform testing while maintaining efficient use of TestContainers.
Changes Made
1. GitHub Actions Workflow Enhancement
ubuntu-latestandwindows-latest2. Test Project Platform Detection
$(CI)to MSBuild's$([MSBuild]::IsOSPlatform('Linux'))for more accurate platform detectionnet8.0with full TestContainer integration test supportnet48(.NET Framework) focusing on unit testsBenefits
Testing Behavior
Ubuntu (Linux):
net8.0trueWindows:
net48(.NET Framework 4.8)falseThis approach maximizes test coverage while working within the constraints that database vendors like Microsoft don't publish Windows images for SQL Server containers.
Fixes #2161.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.