Skip to content

Improve PR pipeline: more integration envs and test infos to the pipeline#2148

Merged
jzabroski merged 32 commits into
fluentmigrator:mainfrom
PhenX:feature-enable-containers
Sep 6, 2025
Merged

Improve PR pipeline: more integration envs and test infos to the pipeline#2148
jzabroski merged 32 commits into
fluentmigrator:mainfrom
PhenX:feature-enable-containers

Conversation

@PhenX

@PhenX PhenX commented Sep 3, 2025

Copy link
Copy Markdown
Collaborator
  • Adds SQLite, Oracle and Postgresql to the integration tests in the pipeline
  • Adds test results and test coverage to the pull requests

@PhenX
PhenX requested a review from jzabroski as a code owner September 3, 2025 17:55
name: Build & Test
runs-on: ubuntu-latest
permissions: write-all
permissions:

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a mistake that this was write-all without changing the trigger to be pull_request_target. From Google Gemini:

In GitHub Actions, pull_request and pull_request_target are distinct event triggers for workflows, primarily differing in their security context and the code they execute.
pull_request:

Context:

Runs in the context of the merge commit of the pull request. This means it executes the workflow file as it exists in the pull request's branch, after it's virtually merged with the base branch.

Permissions:

By default, workflows triggered by pull_request events from forks have limited permissions and cannot access secrets from the base repository. This is a security measure to prevent untrusted code from accessing sensitive information.

Use cases:

Ideal for tasks like running tests, linting, or static analysis on the proposed changes within the pull request's scope, where access to repository secrets or write permissions on the base repository are not required.

pull_request_target:

Context:

Runs in the context of the base of the pull request, which is the branch the pull request is targeting (e.g., main). This means it executes the workflow file as it exists in the base branch, not the potentially modified version in the pull request's branch.

Permissions:

Grants workflows access to repository secrets and provides a read/write GITHUB_TOKEN, even for pull requests originating from forks. This makes it more powerful but also carries higher security risks if not handled carefully.

Use cases:

Required for actions that need to interact with protected resources or modify the base repository, such as deploying preview environments, adding labels or comments to pull requests, or performing operations that require elevated permissions.

@jzabroski

Copy link
Copy Markdown
Collaborator

@PhenX Once I merge #2156, please integrate the change and add

permissions:
   issues: write

Then I think you are good to go.

@jzabroski jzabroski added this to the 7.2.0 milestone Sep 6, 2025
@jzabroski
jzabroski merged commit b58bd89 into fluentmigrator:main Sep 6, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants