CS1591 warnings#2139
Conversation
|
@github update this PR with an additional commit that adds where appropriate: /// You can use the build result from the prior commit fir CS1591 warnings as a hint. |
…pt: Fix all CS1591 errors in this file. Use <inheritdoc /> where appropriate.
|
@PhenX I am out of Copilot free tier tokens. But I think I made a pretty huge dent in the CS1591 warnings with it. My tokens reset on 9/5. So, may be possible to get a lot more progress by end of next week. |
|
2181 Warning(s) left. So knocked off about 33% of the warnings. |
|
I'm going to give this VS2022 plug-in a shot to automate the rest: https://marketplace.visualstudio.com/items?itemName=jinyafeng.DocumentationAssistant |
|
Next good candidates for one-shot prompt:
2. GeneratorBase 33
3. GenericGenerator 49
4. GenericQuoter
5. RunnerContext 23
6. ProcessorBase 54
7. Db2Processor - missed this one when doing all the processors
8. FirebirdTruncator 35
9. FirebirdSchemaInfo 62
10. JetProcesor 25
|
… from VS Marketplace
|
2138 warnings |
…rs in this file. Use <inheritdoc /> where appropriate.
|
1664 warnings |
|
1579 warnings |
…g-in from VS Marketplace
… file. Use <inheritdoc /> where appropriate.
|
1383 warnings |
| /// </summary> | ||
| /// <remarks> | ||
| /// This class provides mappings between .NET <see cref="DbType"/> values and their corresponding Firebird SQL types. | ||
| /// It extends the <see cref="TypeMapBase"/> class and implements the <see cref="IFirebirdTypeMap"/> interface. |
There was a problem hiding this comment.
This kind of comments make me think of this 😅
Do we need to repeat the implements and inherits ?
There was a problem hiding this comment.
It's all automated. I don't like it but the marginal cost of my time to remove it is higher than to keep it right now. Feel free to add to this PR to remove it. Even with Copilot and DocumentationAssistant, it takes time to go through all these warnings. It's 8+ years of tech debt.
There was a problem hiding this comment.
Yeah, that's great that you do this ! About warnings, did you see my suggestion about IQuoter warnings ? I tried it and it works well
|
917 warnings left |
|
460 warnings |
|
354 warnings |
|
0 CS1591 warnings |
2 participants
No description provided.