Skip to content

Computed columns integration tests#2131

Merged
jzabroski merged 30 commits into
fluentmigrator:mainfrom
PhenX:computed_columns_integration_tests
Sep 1, 2025
Merged

Computed columns integration tests#2131
jzabroski merged 30 commits into
fluentmigrator:mainfrom
PhenX:computed_columns_integration_tests

Conversation

@PhenX

@PhenX PhenX commented Aug 28, 2025

Copy link
Copy Markdown
Collaborator

No description provided.

@jzabroski

Copy link
Copy Markdown
Collaborator

There are 7 failing tests, e.g.

Stack Trace:
at FluentMigrator.Tests.Integration.MigrationRunnerTests.<>c.<CanRunMigrations>b__17_1(IServiceProvider serviceProvider, ProcessorBase _) in /home/runner/work/fluentmigrator/fluentmigrator/test/FluentMigrator.Tests/Integration/MigrationRunnerTests.cs:line 514
at FluentMigrator.Tests.Integration.IntegrationTestBase.ExecuteWithProcessor(Type processorType, Action1 initAction, Action2 testAction, Func1 serverOptionsGetter, Boolean tryRollback) in /home/runner/work/fluentmigrator/fluentmigrator/test/FluentMigrator.Tests/Integration/IntegrationTestBase.cs:line 140 at FluentMigrator.Tests.Integration.MigrationRunnerTests.CanRunMigrations(Type processorType, Func1 serverOptions) in /home/runner/work/fluentmigrator/fluentmigrator/test/FluentMigrator.Tests/Integration/MigrationRunnerTests.cs:line 498
at InvokeStub_MigrationRunnerTests.CanRunMigrations(Object, Span`1)
at System.Reflection.MethodBaseInvoker.InvokeWithFewArgs(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)

@PhenX
PhenX marked this pull request as ready for review August 31, 2025 21:41
@PhenX
PhenX requested a review from jzabroski as a code owner August 31, 2025 21:41
@jzabroski
jzabroski merged commit 5839adb into fluentmigrator:main Sep 1, 2025
1 check passed
@jzabroski jzabroski added this to the 7.2.0 milestone Sep 1, 2025
@jzabroski jzabroski mentioned this pull request Sep 1, 2025
5 tasks
@Shane32

Shane32 commented Apr 16, 2026

Copy link
Copy Markdown
Contributor

@jzabroski @PhenX FYI, version 7.2.0 release notes put this PR in the "Code Infrastructure Improvements / Code Style Clean-up" category, when actually this PR is inclusive of the feature itself as well as a few final fixes to tests. I'd suggest moving it to the "Features" category and removing the word "tests" so its more readily understood to be a new feature.

@jzabroski

Copy link
Copy Markdown
Collaborator

OK, doing that now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants