Skip to content

Improve MicrosoftBuildLogger.#1905

Merged
jzabroski merged 2 commits into
fluentmigrator:mainfrom
teo-tsirpanis:fix-msbuild-logger
Oct 5, 2024
Merged

Improve MicrosoftBuildLogger.#1905
jzabroski merged 2 commits into
fluentmigrator:mainfrom
teo-tsirpanis:fix-msbuild-logger

Conversation

@teo-tsirpanis

Copy link
Copy Markdown
Contributor

This PR:

  • Makes code more concise.
  • Fixes IsEnabled returning wrong results for errors and warnings if informational messages are disabled.
  • Fixes compatibility with MSBuild versions prior to 17, by handling the LogsMessagesOfImportance method not existing.

@jzabroski
jzabroski merged commit a8985e0 into fluentmigrator:main Oct 5, 2024
@teo-tsirpanis
teo-tsirpanis deleted the fix-msbuild-logger branch October 5, 2024 12:05
@jzabroski jzabroski added this to the 6.3.0 milestone Oct 5, 2024
@jzabroski

Copy link
Copy Markdown
Collaborator

Thank you! If you're ever in Boston, look me up!

@jzabroski jzabroski modified the milestones: 6.3.0, 7.0.0 Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants