Add BeApproximately version for both subject and expected nullable#934
Merged
jnyrup merged 3 commits intofluentassertions:masterfrom Oct 2, 2018
Merged
Conversation
krajek
changed the title
BeApproximately for both subject and expected of type double?BeApproximately version for both subject and expected nullable
jnyrup
approved these changes
Oct 1, 2018
dennisdoomen
approved these changes
Oct 2, 2018
krajek
force-pushed
the
expected_numeric_nullable
branch
from
804f688 to
3f33cc2
Compare
krajek
force-pushed
the
expected_numeric_nullable
branch
from
675c41f to
612a1e3
Compare
krajek
changed the title
BeApproximately version for both subject and expected nullableBeApproximately version for both subject and expected nullable
Contributor
Author
|
PR is ready. |
Member
|
@krajek to quote an incredible active contributor (hint, it's you!)
I didn't think about |
Member
|
Yeah, I wonder where @krajek is getting the time from.... ;-) |
This was referenced Oct 3, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #922.
For now, I have tackled only the case of
double?.Please review. Upon approval, I will copy the logic and tests for
float?anddecimal?.