Skip to content

Add ThrowAsync, ThrowExactlyAsync and NotThrowAsync#931

Merged
jnyrup merged 4 commits intofluentassertions:masterfrom
krajek:throw_and_not_throw_async
Oct 1, 2018
Merged

Add ThrowAsync, ThrowExactlyAsync and NotThrowAsync#931
jnyrup merged 4 commits intofluentassertions:masterfrom
krajek:throw_and_not_throw_async

Conversation

@krajek
Copy link
Copy Markdown
Contributor

@krajek krajek commented Sep 29, 2018

Closes #851.

jnyrup
jnyrup requested changes Sep 29, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@jnyrup jnyrup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other exception assertions have the ThrowExactly extension located in AssertionExtensions.Actions.cs.
To provide the same set of assertions for the async version, ThrowExactlyAsync should be added.

It would be nice with a test exercising that ThrowAsync<TException> also works for derived types of TException, like When_subject_throws_subclass_of_expected_exact_exception_it_should_fail does.

@krajek krajek force-pushed the throw_and_not_throw_async branch from 1fe1a12 to 1d140fa Compare September 29, 2018 18:05
@krajek
Copy link
Copy Markdown
Contributor Author

krajek commented Sep 29, 2018

@jnyrup I have just added ThrowExactlyAsync. Ready to merge from my side.

@krajek krajek changed the title Add ThrowAsync and NotThrowAsync Add ThrowAsync, ThrowExactlyAsync and NotThrowAsync Sep 29, 2018
jnyrup
jnyrup approved these changes Sep 30, 2018
View reviewed changes
@krajek krajek force-pushed the throw_and_not_throw_async branch from 1d140fa to d2de932 Compare September 30, 2018 18:20
@krajek
Copy link
Copy Markdown
Contributor Author

krajek commented Sep 30, 2018

I have just completed fixes after the second review

@jnyrup jnyrup merged commit 4982935 into fluentassertions:master Oct 1, 2018
@krajek krajek deleted the throw_and_not_throw_async branch October 1, 2018 05:39
@nerdpad
Copy link
Copy Markdown

nerdpad commented Oct 31, 2018

Any plans of release this soon? I just started using FluentAssertion and this is exactly what I needed.

@jnyrup
Copy link
Copy Markdown
Member

jnyrup commented Oct 31, 2018

@nerdpad yes, we're also quite eager to get out a new release with all the new features, fixes and other improvements.
We're finishing up the last PRs for 5.5.0, see the remaining ones here https://github.com/fluentassertions/fluentassertions/milestone/12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dennisdoomen dennisdoomen dennisdoomen approved these changes

@jnyrup jnyrup jnyrup approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@krajek @nerdpad @jnyrup @dennisdoomen